Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix time() infinite loop #2820

Merged
merged 2 commits into from
Sep 9, 2021
Merged

fix time() infinite loop #2820

merged 2 commits into from
Sep 9, 2021

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Sep 8, 2021

Fixes #2566

@Shylock-Hg
Copy link
Contributor

Why lead to inifinite loop?

@czpmango
Copy link
Contributor Author

czpmango commented Sep 8, 2021

Why lead to inifinite loop?

The future's return was not triggered because of the exception, and the current request remained in the asynchronous queue.
When an infinite loop occurs, the log after graphd exits is as follows:

E0908 17:45:09.338558 13136 Cpp2Worker.cpp:369] Failed to join outstanding requests.
F0908 17:45:09.339707 13136 ThriftServer.cpp:585] Could not drain active requests within allotted deadline. 
Deadline value: 30 secs. Abort because undefined behavior is possible. 
Underlying reasons could be either requests that have never terminated, long running requests, or long queues that could not be fully processed.

@Shylock-Hg
Copy link
Contributor

Why lead to inifinite loop?

The future's return was not triggered because of the exception, and the current request remained in the asynchronous queue.
When an infinite loop occurs, the log after graphd exits is as follows:

E0908 17:45:09.338558 13136 Cpp2Worker.cpp:369] Failed to join outstanding requests.
F0908 17:45:09.339707 13136 ThriftServer.cpp:585] Could not drain active requests within allotted deadline. 
Deadline value: 30 secs. Abort because undefined behavior is possible. 
Underlying reasons could be either requests that have never terminated, long running requests, or long queues that could not be fully processed.

Ok, maybe we could add dcheck to help avoid this issue.

@yixinglu yixinglu merged commit ad97b8e into vesoft-inc:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception in visitor results in an infinite loop
4 participants