-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix insert edge #2862
fix insert edge #2862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix what problem? could you give some cases ?
In the case of multiple replicas, insert statements may cause inconsistent attribute values between replicas.
|
Between partitions instead of replicas. |
You are right. |
Add case to compare properties of in/out edges |
Close #2867 |
We are testing TOSS feature, not sure this is the same problem you are confronting. |
TOSS is another way could resolve this problem. |
Sadly TOSS cannot fix too. The problem issue #2867 mentioning is the mismatch of int value of edge props without default. BTW @liuyu85cn has already did some fix for the default timestamp() value mismatch at the storage level. |
Could resolve the default value issue. |
This pr and issue #2739 has nothing to do with toss, it is just to fix |
2e3c220
to
d88699b
Compare
std::vector<Value> entirePropValues; | ||
for (size_t j = 0; j < fieldNum; ++j) { | ||
auto *field = schema_->field(j); | ||
auto propName = entirePropNames_[j]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the entirePropNames_
is not necessary, why not use schema_->field(j)->name()
here directly. And you needs not to save it as the field of MutateValidator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also used in InsertEdgesValidator::toPlan()
.
Fixes #2739