Change limit to expression. #2878
Conversation
|
|
||
| Limit(QueryContext* qctx, PlanNode* input, int64_t offset, Expression* count) | ||
| : SingleInputNode(qctx, Kind::kLimit, input) { | ||
| offset_ = offset; | ||
| count_ = count; | ||
| } | ||
|
|
||
| void cloneMembers(const Limit&); | ||
|
|
||
| private: | ||
| int64_t offset_{-1}; |
There was a problem hiding this comment.
Need change offset_ into an expression?
There was a problem hiding this comment.
offset won't push down
There was a problem hiding this comment.
It is better to ensure consistency in use.
go from ....| offset abs(1)+3 limit abs(3)+1
go from ....| limit abs(3)+1,abs(3)
There was a problem hiding this comment.
This is used for new syntax for go ... limit [..]
| int64_t count() const { | ||
| if (count_ == nullptr) { | ||
| return -1; | ||
| } | ||
| DCHECK(ExpressionUtils::isEvaluableExpr(count_)); | ||
| QueryExpressionContext ctx; | ||
| return count_->eval(ctx).getInt(); | ||
| } |
There was a problem hiding this comment.
Is this interface necessary?
|
Subjob of #2602 |
| @@ -50,6 +50,10 @@ StatusOr<OptRule::TransformResult> LimitPushDownRule::transform( | |||
| const auto proj = static_cast<const Project *>(projGroupNode->node()); | |||
| const auto gn = static_cast<const GetNeighbors *>(gnGroupNode->node()); | |||
|
|
|||
| DCHECK(graph::ExpressionUtils::isEvaluableExpr(limit->countExpr())); | |||
There was a problem hiding this comment.
Don't use DCHECK to debug your code if it's the regular branch you need to handle.
There was a problem hiding this comment.
This won't happen in correct state.
There was a problem hiding this comment.
So why did you do the same check in line 54?
There was a problem hiding this comment.
Handle exception scenes
Push down limit to GN in Loop for each step. |
|
Include in #2853 |
For the limit push down in Loop
Subjob of #2602