Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format lookup #2895

Merged
merged 6 commits into from
Sep 27, 2021
Merged

format lookup #2895

merged 6 commits into from
Sep 27, 2021

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Sep 17, 2021 •
edited
Loading

support YIELD vertex OR edge

@nevermore3 nevermore3 added the wip Solution: work in progress label Sep 17, 2021
@nevermore3
Copy link
Contributor Author

subjob of #2594

@nevermore3 nevermore3 force-pushed the format_lookup branch 8 times, most recently from 22046e3 to 455ee09 Compare September 18, 2021 03:45
@nevermore3 nevermore3 force-pushed the format_lookup branch 3 times, most recently from e58bc13 to 2dfa9ba Compare September 18, 2021 08:57
@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test and removed wip Solution: work in progress labels Sep 18, 2021
@nevermore3 nevermore3 force-pushed the format_lookup branch 2 times, most recently from 6ed11a9 to 9898ed1 Compare September 18, 2021 09:04
@Sophie-Xie Sophie-Xie removed the request for review from a team September 22, 2021 02:15
yixinglu
yixinglu previously approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nevermore3 nevermore3 added the doc affected PR: improvements or additions to documentation label Sep 24, 2021
yixinglu
yixinglu approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021 •
edited
Loading

Codecov Report

Merging #2895 (2ca3190) into master (dddf54e) will decrease coverage by 0.70%.
The diff coverage is 62.93%.

❗ Current head 2ca3190 differs from pull request most recent head a70cf08. Consider uploading reports for the commit a70cf08 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2895      +/-   ##
==========================================
- Coverage   85.47%   84.77%   -0.71%     
==========================================
  Files        1229     1231       +2     
  Lines      110375   110815     +440     
==========================================
- Hits        94341    93940     -401     
- Misses      16034    16875     +841
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 92.30% <ø> (ø)
src/common/utils/NebulaKeyUtils.cpp 89.03% <0.00%> (-4.89%) ⬇️
src/common/utils/NebulaKeyUtils.h 78.02% <ø> (ø)
src/graph/planner/plan/Admin.cpp 54.23% <0.00%> (-2.40%) ⬇️
src/graph/planner/plan/PlanNode.h 80.00% <ø> (ø)
src/graph/service/PermissionCheck.cpp 83.72% <ø> (+2.32%) ⬆️
src/kvstore/KVEngine.h 100.00% <ø> (ø)
src/kvstore/RocksEngine.cpp 81.79% <0.00%> (-1.73%) ⬇️
src/kvstore/RocksEngine.h 66.66% <0.00%> (-25.00%) ⬇️
src/meta/MetaServiceHandler.h 100.00% <ø> (ø)
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e18809b...a70cf08. Read the comment docs.

bright-starry-sky
bright-starry-sky approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@bright-starry-sky bright-starry-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@bright-starry-sky bright-starry-sky merged commit 073fb37 into vesoft-inc:master Sep 27, 2021
@nevermore3 nevermore3 deleted the format_lookup branch September 27, 2021 03:19
@jamieliu1023 jamieliu1023 mentioned this pull request Oct 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@bright-starry-sky bright-starry-sky bright-starry-sky approved these changes

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nevermore3 @codecov-commenter @yixinglu @bright-starry-sky