format go yield #2944
Merged
format go yield #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
added
doc affected
|
subjob of #2594 |
nevermore3
force-pushed
the
format_go
branch
11 times, most recently
from
41066e3 to
f52cee7
Compare
nevermore3
force-pushed
the
format_go
branch
from
f52cee7 to
dccaea0
Compare
nevermore3
added
ready-for-testing
yixinglu
reviewed
Sep 30, 2021
nevermore3
force-pushed
the
format_go
branch
from
f2c4ad7 to
5b5fa01
Compare
yixinglu
reviewed
Sep 30, 2021
CPWstatic
previously approved these changes
Sep 30, 2021
yixinglu
reviewed
Sep 30, 2021
yixinglu
reviewed
Sep 30, 2021
| for (auto* col : goCtx_->yieldExpr->columns()) { | ||
| auto* vertexExpr = ExpressionUtils::findAny(col->expr(), {Expression::Kind::kVertex}); | ||
| if (vertexExpr != nullptr) { | ||
| const auto& colName = static_cast<const VertexExpression*>(vertexExpr)->name(); |
There was a problem hiding this comment.
if (existExpr.count(colName)==0) {
if (colName == SRC) {
} else if (colName == DST) {}
existExpr[colName] = true;
}
yixinglu
approved these changes
Sep 30, 2021
CPWstatic
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$^ represents the starting point of the edge
$$ represents the destination point of the edge
go from 'a' over * yield$^ as startNode, $ $ as endNode, edge as relationship
the type of$^ and $ $ is VERTEX, must add alias when use $^ or $ $