format find path #2957

nevermore3 · 2021-09-28T03:22:26Z

must add YIELD path in findpath sentence

incompatible
KW_PATH changed from non-keyword to keyword, so disallow users to define path as a variable .
some test case :
find path from a to b over like |order by $-.path or. match path = (a)-[]->(b) return path. are not allowed

nevermore3 · 2021-09-28T03:23:18Z

subjob of #2594

.linters/cpp/checkKeyword.py

src/parser/parser.yy

codecov-commenter · 2021-10-23T16:24:21Z

Codecov Report

Merging #2957 (923536b) into master (80e827f) will decrease coverage by 0.01%.
The diff coverage is 91.35%.

@@            Coverage Diff             @@
##           master    #2957      +/-   ##
==========================================
- Coverage   85.24%   85.22%   -0.02%     
==========================================
  Files        1289     1289              
  Lines      120035   120077      +42     
==========================================
+ Hits       102322   102337      +15     
- Misses      17713    17740      +27

Impacted Files	Coverage Δ
src/graph/optimizer/OptGroup.h	`100.00% <ø> (ø)`
src/graph/optimizer/Optimizer.h	`100.00% <ø> (ø)`
src/graph/optimizer/OptimizerUtils.cpp	`94.00% <ø> (ø)`
...h/optimizer/rule/GeoPredicateIndexScanBaseRule.cpp	`96.20% <ø> (ø)`
src/graph/optimizer/rule/IndexScanRule.cpp	`71.98% <ø> (ø)`
...timizer/rule/OptimizeEdgeIndexScanByFilterRule.cpp	`90.54% <ø> (ø)`
...ptimizer/rule/OptimizeTagIndexScanByFilterRule.cpp	`90.27% <ø> (ø)`
...graph/optimizer/rule/PushFilterDownGetNbrsRule.cpp	`75.51% <ø> (ø)`
...imizer/rule/PushLimitDownEdgeIndexFullScanRule.cpp	`89.65% <ø> (ø)`
...izer/rule/PushLimitDownEdgeIndexPrefixScanRule.cpp	`89.65% <ø> (ø)`
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e827f...923536b. Read the comment docs.

nevermore3 · 2021-10-25T10:15:03Z

subjob of #3135

Shylock-Hg · 2021-10-27T06:42:22Z

src/graph/validator/FindPathValidator.cpp

+    return Status::SemanticError("Missing yield clause.");
+  }
+  if (yield->columns().size() != 1) {
+    return Status::SemanticError("Only support yield path");


`YIELD path`

lower case is also ok

Shylock-Hg · 2021-10-27T06:58:33Z

tests/tck/features/path/AllPath.IntVid.feature

@@ -278,3 +278,60 @@ Feature: Integer Vid All Path
      | <("Tim Duncan" :bachelor{name: "Tim Duncan", speciality: "psychology"} :player{age: 42, name: "Tim Duncan"})-[:like@0 {likeness: 95}]->("Manu Ginobili" :player{age: 41, name: "Manu Ginobili"})<-[:like@0 {likeness: 95}]-("Tony Parker" :player{age: 36, name: "Tony Parker"})>         |
      | <("Tim Duncan" :bachelor{name: "Tim Duncan", speciality: "psychology"} :player{age: 42, name: "Tim Duncan"})<-[:like@0 {likeness: 80}]-("Boris Diaw" :player{age: 36, name: "Boris Diaw"})-[:like@0 {likeness: 80}]->("Tony Parker" :player{age: 36, name: "Tony Parker"})>               |
    Then drop the used space
+
+  Scenario: Integer Vid ALL PATH YIELD PATH


Add some cases to test invalid yield clause.

alread exists in unit test

nevermore3 added the doc affected PR: improvements or additions to documentation label Sep 28, 2021

nevermore3 added this to the v2.6.0 milestone Sep 28, 2021

nevermore3 force-pushed the format_path branch from d84c289 to 13c8897 Compare September 28, 2021 05:24

nevermore3 requested review from yixinglu and CPWstatic September 28, 2021 05:27

nevermore3 added the incompatible PR: incompatible with the recently released version label Sep 28, 2021

nevermore3 force-pushed the format_path branch from 13c8897 to 1fd361c Compare September 28, 2021 06:26

nevermore3 added the ready-for-testing PR: ready for the CI test label Sep 28, 2021

nevermore3 requested a review from Shylock-Hg September 28, 2021 06:55

Shylock-Hg reviewed Sep 28, 2021

View reviewed changes

.linters/cpp/checkKeyword.py Show resolved Hide resolved

nevermore3 force-pushed the format_path branch 3 times, most recently from e0233df to 76c054e Compare September 30, 2021 06:37

yixinglu reviewed Sep 30, 2021

View reviewed changes

src/parser/parser.yy Outdated Show resolved Hide resolved

yixinglu previously approved these changes Sep 30, 2021

View reviewed changes

nevermore3 removed the ready-for-testing PR: ready for the CI test label Oct 1, 2021

nevermore3 dismissed yixinglu’s stale review via e47bad0 October 8, 2021 02:26

nevermore3 force-pushed the format_path branch from 0da7322 to e47bad0 Compare October 8, 2021 02:26

Sophie-Xie modified the milestones: v2.6.0, v2.7.0 Oct 9, 2021

nevermore3 force-pushed the format_path branch from e47bad0 to 60e34cd Compare October 11, 2021 13:00

Sophie-Xie modified the milestones: v2.7.0, v3.0.0 Oct 15, 2021

nevermore3 force-pushed the format_path branch from 60e34cd to ef2c8a0 Compare October 20, 2021 12:40

nevermore3 added the ready-for-testing PR: ready for the CI test label Oct 21, 2021

nevermore3 force-pushed the format_path branch from ef2c8a0 to 0aea981 Compare October 22, 2021 09:03

nevermore3 added do not review PR: not ready for the code review yet and removed ready-for-testing PR: ready for the CI test labels Oct 22, 2021

nevermore3 force-pushed the format_path branch from 0aea981 to 543dd54 Compare October 23, 2021 14:24

CPWstatic previously approved these changes Oct 26, 2021

View reviewed changes

nevermore3 dismissed CPWstatic’s stale review via 07e7aa6 October 26, 2021 07:14

nevermore3 force-pushed the format_path branch 2 times, most recently from 07e7aa6 to 66be3b0 Compare October 26, 2021 08:03

Shylock-Hg reviewed Oct 27, 2021

View reviewed changes

nevermore3 force-pushed the format_path branch from 66be3b0 to 29fd53f Compare November 5, 2021 07:24

CPWstatic previously approved these changes Nov 18, 2021

View reviewed changes

nevermore3 dismissed CPWstatic’s stale review via e9f9830 November 22, 2021 11:33

nevermore3 force-pushed the format_path branch from f2bf640 to e9f9830 Compare November 22, 2021 11:33

nevermore3 added 10 commits November 23, 2021 00:13

format find path

ef4c3c8

add test case

96437bf

only support yield path

f74b68f

fix test error

801a111

address comment

4159847

fix error

1e71741

add yield clause

3c1bc67

fix ci test

5282b7a

remove reduncant header file

3041aee

fix clang compiler error

ab1d56e

nevermore3 force-pushed the format_path branch from e9f9830 to ab1d56e Compare November 22, 2021 16:13

fix spell error

923536b

Aiee approved these changes Nov 23, 2021

View reviewed changes

CPWstatic approved these changes Nov 23, 2021

View reviewed changes

CPWstatic merged commit 6cdca05 into vesoft-inc:master Nov 23, 2021

nevermore3 deleted the format_path branch November 23, 2021 03:52

jamieliu1023 mentioned this pull request Nov 27, 2021

Weekly Report 2021-11-26 vesoft-inc/nebula-community#49

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

format find path #2957

format find path #2957

nevermore3 commented Sep 28, 2021 •

edited

Loading

nevermore3 commented Sep 28, 2021

codecov-commenter commented Oct 23, 2021 •

edited

Loading

nevermore3 commented Oct 25, 2021

Shylock-Hg Oct 27, 2021 •

edited

Loading

nevermore3 Nov 5, 2021

Shylock-Hg Oct 27, 2021

nevermore3 Nov 5, 2021

format find path #2957

format find path #2957

Conversation

nevermore3 commented Sep 28, 2021 • edited Loading

nevermore3 commented Sep 28, 2021

codecov-commenter commented Oct 23, 2021 • edited Loading

Codecov Report

nevermore3 commented Oct 25, 2021

Shylock-Hg Oct 27, 2021 • edited Loading

Choose a reason for hiding this comment

nevermore3 Nov 5, 2021

Choose a reason for hiding this comment

Shylock-Hg Oct 27, 2021

Choose a reason for hiding this comment

nevermore3 Nov 5, 2021

Choose a reason for hiding this comment

nevermore3 commented Sep 28, 2021 •

edited

Loading

codecov-commenter commented Oct 23, 2021 •

edited

Loading

Shylock-Hg Oct 27, 2021 •

edited

Loading