Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug#3048 #3069

Merged
merged 2 commits into from
Oct 14, 2021
Merged

fix bug#3048 #3069

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
691cdfc
fix bug#3048
zhaohaifei Oct 14, 2021
fd8ea13
Merge branch 'master' into bug#3048
zhaohaifei Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/graph/service/GraphService.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,16 @@ Status GraphService::init(std::shared_ptr<folly::IOThreadPoolExecutor> ioExecuto
bool loadDataOk = metaClient_->waitForMetadReady(3);
if (!loadDataOk) {
// Resort to retrying in the background
LOG(WARNING) << "Failed to wait for meta service ready synchronously.";
LOG(ERROR) << "Failed to wait for meta service ready synchronously.";
return Status::Error("Failed to wait for meta service ready synchronously.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why log and return the same error msg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second log is for upper calling.

}

sessionManager_ = std::make_unique<GraphSessionManager>(metaClient_.get(), hostAddr);
auto initSessionMgrStatus = sessionManager_->init();
if (!initSessionMgrStatus.ok()) {
LOG(WARNING) << "Failed to initialize session manager: " << initSessionMgrStatus.toString();
LOG(ERROR) << "Failed to initialize session manager: " << initSessionMgrStatus.toString();
return Status::Error("Failed to initialize session manager: %s",
initSessionMgrStatus.toString().c_str());
}

queryEngine_ = std::make_unique<QueryEngine>();
Expand Down