Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Remove some read-write locks in meta client #3158

Closed
wants to merge 0 commits into from

Conversation

jackwener
Copy link
Contributor

Related Issue

issue: #3129

Note

The code modification is from code of v1.2.

Remove unnecessary locks.

@jackwener jackwener requested a review from Sophie-Xie October 20, 2021 03:28
@Sophie-Xie Sophie-Xie requested review from critical27 and CPWstatic and removed request for Sophie-Xie October 20, 2021 03:29
@Sophie-Xie Sophie-Xie added this to the v3.0.0 milestone Oct 20, 2021
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Oct 20, 2021
@jackwener jackwener added the wip Solution: work in progress label Oct 20, 2021
@jackwener jackwener changed the title Remove some read-write locks in meta client [WIP]: Remove some read-write locks in meta client Oct 20, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3158 (3fabd9f) into master (d05ca51) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3158      +/-   ##
==========================================
+ Coverage   84.98%   85.02%   +0.04%     
==========================================
  Files        1289     1289              
  Lines      117763   117746      -17     
==========================================
+ Hits       100076   100115      +39     
+ Misses      17687    17631      -56     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.cpp 74.95% <ø> (+0.23%) ⬆️
src/graph/util/ToJson.h 100.00% <ø> (ø)
src/graph/validator/ACLValidator.cpp 85.07% <ø> (ø)
src/graph/validator/ACLValidator.h 100.00% <ø> (ø)
src/graph/validator/AdminValidator.cpp 78.78% <ø> (ø)
src/graph/validator/AdminValidator.h 67.53% <ø> (ø)
src/graph/validator/BalanceValidator.cpp 0.00% <ø> (ø)
src/graph/validator/DownloadValidator.cpp 0.00% <ø> (ø)
src/graph/validator/DownloadValidator.h 0.00% <ø> (ø)
src/graph/validator/FindPathValidator.h 100.00% <ø> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f48045...3fabd9f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test wip Solution: work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants