Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable lookup yield agg function #3245

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Nov 1, 2021

What type of PR is this?

  • bug

Which issue(s) this PR fixes:

close #3230

What this PR does / why we need it?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

PathbuildExpression is for internal use, users cannot construct pathbuildExpression, so no need validate

Checklist:

  • Documentation affected (If need to modify document, please label it.)
  • Incompatible (If it is incompatile, please describle it and label it.)
  • Need to cherry pick (If need to cherry pick to some branchs, please label the destination version(s).)
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@nevermore3 nevermore3 added type/bug Type: something is unexpected ready-for-testing PR: ready for the CI test labels Nov 1, 2021
Shylock-Hg
Shylock-Hg previously approved these changes Nov 1, 2021
yixinglu
yixinglu previously approved these changes Nov 1, 2021
@nevermore3 nevermore3 dismissed stale reviews from yixinglu and Shylock-Hg via 776e47c November 1, 2021 10:25
@@ -90,3 +90,10 @@ Feature: Lookup with yield
| "Marco Belinelli" | "Tony Parker" | 0 | 50 | [:like "Marco Belinelli"->"Tony Parker" @0 {likeness: 50}] |
| "Rajon Rondo" | "Ray Allen" | 0 | -1 | [:like "Rajon Rondo"->"Ray Allen" @0 {likeness: -1}] |
| "Ray Allen" | "Rajon Rondo" | 0 | 9 | [:like "Ray Allen"->"Rajon Rondo" @0 {likeness: 9}] |
When executing query:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no such testcase before

@yixinglu yixinglu merged commit 8e69e6b into vesoft-inc:master Nov 2, 2021
@nevermore3 nevermore3 deleted the fix_lookup_crash branch November 2, 2021 02:42
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Nov 2, 2021
* disable lookup yield agg function

* add ci case
yixinglu added a commit that referenced this pull request Nov 3, 2021
* Build ARM platform docker images (#3240)

* Build docker image for arm64 platform

* Fix shell check error in GitHub action runner

* build arm platform image nightly

* Cleanup v2-nightly image

* disable lookup yield agg function (#3245)

* disable lookup yield agg function

* add ci case

Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Sophie-Xie pushed a commit that referenced this pull request Nov 3, 2021
* disable lookup yield agg function

* add ci case
CPWstatic pushed a commit that referenced this pull request Nov 3, 2021
* disable lookup yield agg function

* add ci case

Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Services down if |omitted in statements like LOOKUP ON player | YIELD COUNT(*) AS Player_Number
4 participants