-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable lookup yield agg function #3245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
added
type/bug
Type: something is unexpected
ready-for-testing
PR: ready for the CI test
labels
Nov 1, 2021
Shylock-Hg
previously approved these changes
Nov 1, 2021
yixinglu
previously approved these changes
Nov 1, 2021
Shylock-Hg
reviewed
Nov 1, 2021
@@ -90,3 +90,10 @@ Feature: Lookup with yield | |||
| "Marco Belinelli" | "Tony Parker" | 0 | 50 | [:like "Marco Belinelli"->"Tony Parker" @0 {likeness: 50}] | | |||
| "Rajon Rondo" | "Ray Allen" | 0 | -1 | [:like "Rajon Rondo"->"Ray Allen" @0 {likeness: -1}] | | |||
| "Ray Allen" | "Rajon Rondo" | 0 | 9 | [:like "Ray Allen"->"Rajon Rondo" @0 {likeness: 9}] | | |||
When executing query: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no such testcase before
CPWstatic
approved these changes
Nov 2, 2021
Shylock-Hg
approved these changes
Nov 2, 2021
yixinglu
approved these changes
Nov 2, 2021
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Nov 2, 2021
* disable lookup yield agg function * add ci case
yixinglu
added a commit
that referenced
this pull request
Nov 3, 2021
* Build ARM platform docker images (#3240) * Build docker image for arm64 platform * Fix shell check error in GitHub action runner * build arm platform image nightly * Cleanup v2-nightly image * disable lookup yield agg function (#3245) * disable lookup yield agg function * add ci case Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Sophie-Xie
pushed a commit
that referenced
this pull request
Nov 3, 2021
* disable lookup yield agg function * add ci case
CPWstatic
pushed a commit
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
close #3230
What this PR does / why we need it?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
PathbuildExpression is for internal use, users cannot construct pathbuildExpression, so no need validate
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: