-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/scan multiple parts #3262
Feature/scan multiple parts #3262
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3262 +/- ##
==========================================
- Coverage 85.24% 85.23% -0.02%
==========================================
Files 1295 1305 +10
Lines 118190 120394 +2204
==========================================
+ Hits 100748 102612 +1864
- Misses 17442 17782 +340
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, clean code. Only one question, others LGTM.
@@ -557,24 +557,29 @@ struct LookupAndTraverseRequest { | |||
* End of Index section | |||
*/ | |||
|
|||
struct ScanCursor { | |||
3: bool has_next, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The has_next
seems useless, just judge by next_cursor
is enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I just keep the origin fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thx!
Overall it's ok. There is a small problem. I think from the perspective of a volcano model, only the leaf nodes TagNode/EdgeNode need to access |
Yes, the ScanNode is too heavy, refactor in volcano model maybe is better. |
What type of PR is this?
Which issue(s) this PR fixes:
Subjob of #3106
(If it is requirement, issue(s) number must be listed.)
What this PR does / why we need it?
Extend the Scan storage interface to support scan multiple partitions. And ScanVertex will return kVid as first column to keep same with GetProp.
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
@jievince @Nicole00 The scan interface need update.
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: