Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix index degeneration #3311

Merged
merged 12 commits into from
Nov 23, 2021
Merged

fix index degeneration #3311

merged 12 commits into from
Nov 23, 2021

Conversation

czpmango
Copy link
Contributor

Fixes #3246

@czpmango czpmango added ready-for-testing PR: ready for the CI test wip Solution: work in progress do not review PR: not ready for the code review yet labels Nov 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021 •
edited
Loading

Codecov Report

Merging #3311 (7692ea6) into master (80e827f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3311      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.02%     
==========================================
  Files        1289     1289              
  Lines      120035   120036       +1     
==========================================
+ Hits       102322   102350      +28     
+ Misses      17713    17686      -27
Impacted Files Coverage Δ
src/graph/optimizer/rule/IndexScanRule.cpp 86.66% <100.00%> (+14.67%) ⬆️
src/meta/processors/parts/GetSpaceProcessor.cpp 60.60% <0.00%> (-18.19%) ⬇️
src/meta/processors/BaseProcessor.h 75.67% <0.00%> (-16.22%) ⬇️
src/common/thrift/ThriftClientManager-inl.h 82.97% <0.00%> (-6.39%) ⬇️
src/common/datatypes/HostAddrOps-inl.h 72.97% <0.00%> (-5.41%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 74.19% <0.00%> (-4.52%) ⬇️
src/kvstore/raftex/Host.cpp 73.91% <0.00%> (-4.02%) ⬇️
src/parser/GraphScanner.h 91.46% <0.00%> (-2.29%) ⬇️
src/storage/exec/QueryUtils.h 91.42% <0.00%> (-1.78%) ⬇️
src/graph/session/GraphSessionManager.cpp 79.88% <0.00%> (-1.73%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e827f...7692ea6. Read the comment docs.

yixinglu
yixinglu previously approved these changes Nov 12, 2021
View reviewed changes
yixinglu
yixinglu previously approved these changes Nov 15, 2021
View reviewed changes
@czpmango czpmango removed do not review PR: not ready for the code review yet wip Solution: work in progress labels Nov 15, 2021
@czpmango czpmango requested a review from jievince November 15, 2021 09:23
Aiee
Aiee previously approved these changes Nov 15, 2021
View reviewed changes
@czpmango czpmango dismissed stale reviews from Aiee and yixinglu via ba928a8 November 16, 2021 02:23
@czpmango czpmango force-pushed the fix-index branch 2 times, most recently from ba928a8 to 14a1811 Compare November 16, 2021 03:03
yixinglu
yixinglu approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit e8b45d3 into vesoft-inc:master Nov 23, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Nov 27, 2021
Closed
This was referenced Dec 8, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jievince jievince jievince approved these changes

@yixinglu yixinglu yixinglu approved these changes

@Aiee Aiee Aiee left review comments

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Match index degeneration
5 participants
@czpmango @codecov-commenter @yixinglu @Aiee @jievince