Insert vertex only

src/graph/service/PermissionCheck.cpp

@@ -105,6 +105,7 @@ Status PermissionCheck::permissionCheck(ClientSession *session,
  return Status::OK();
  }
  case Sentence::Kind::kInsertVertices:
+ case Sentence::Kind::kInsertVerticesOnly:
  case Sentence::Kind::kUpdateVertex:
  case Sentence::Kind::kInsertEdges:
  case Sentence::Kind::kUpdateEdge:

src/graph/validator/MutateValidator.cpp

@@ -133,6 +133,36 @@ Status InsertVerticesValidator::prepareVertices() {
  return Status::OK();
 }
 
+Status InsertVerticesOnlyValidator::validateImpl() {
+ spaceId_ = vctx_->whichSpace().id;
+ NG_RETURN_IF_ERROR(prepareVertices());
+ return Status::OK();
+}
+
+Status InsertVerticesOnlyValidator::prepareVertices() {
+ auto sentence = static_cast<InsertVerticesOnlySentence *>(sentence_);
+ ifNotExists_ = sentence->ifNotExists();
+ auto vidList = sentence->vertices()->vidList();
+ vertices_.reserve(vidList.size());
+ for (auto vid : vidList) {
+ auto idStatus = SchemaUtil::toVertexID(vid, vidType_);
+ NG_RETURN_IF_ERROR(idStatus);
+ auto vertexID = std::move(idStatus).value();
+ storage::cpp2::NewVertex vertex;
+ vertex.set_id(vertexID);
+ vertices_.emplace_back(std::move(vertex));
+ }
+ return Status::OK();
+}
+
+Status InsertVerticesOnlyValidator::toPlan() {
+ auto node =
+ InsertVertices::make(qctx_, nullptr, spaceId_, std::move(vertices_), {}, ifNotExists_);
+ root_ = node;
+ tail_ = node;
+ return Status::OK();
+}
+
 Status InsertEdgesValidator::validateImpl() {
  spaceId_ = vctx_->whichSpace().id;
  NG_RETURN_IF_ERROR(check());

src/graph/validator/MutateValidator.h

@@ -38,6 +38,20 @@ class InsertVerticesValidator final : public Validator {
  std::vector<storage::cpp2::NewVertex> vertices_;
 };
 
+class InsertVerticesOnlyValidator final : public Validator {
+ public:
+ InsertVerticesOnlyValidator(Sentence* sentence, QueryContext* context)
+ : Validator(sentence, context) {}
+
+ private:
+ Status validateImpl() override;
+ Status prepareVertices();
+ Status toPlan() override;
+ GraphSpaceID spaceId_{-1};
+ std::vector<storage::cpp2::NewVertex> vertices_;
+ bool ifNotExists_;
+};
+
 class InsertEdgesValidator final : public Validator {
  public:
  InsertEdgesValidator(Sentence* sentence, QueryContext* context) : Validator(sentence, context) {}

src/graph/validator/Validator.cpp

@@ -113,6 +113,8 @@ std::unique_ptr<Validator> Validator::makeValidator(Sentence* sentence, QueryCon
  return std::make_unique<ShowCreateEdgeValidator>(sentence, context);
  case Sentence::Kind::kInsertVertices:
  return std::make_unique<InsertVerticesValidator>(sentence, context);
+ case Sentence::Kind::kInsertVerticesOnly:
+ return std::make_unique<InsertVerticesOnlyValidator>(sentence, context);
  case Sentence::Kind::kInsertEdges:
  return std::make_unique<InsertEdgesValidator>(sentence, context);
  case Sentence::Kind::kCreateUser:

src/parser/MutateSentences.cpp

@@ -97,6 +97,17 @@ std::string InsertVerticesSentence::toString() const {
  return buf;
 }
 
+std::string InsertVerticesOnlySentence::toString() const {
+ std::string buf;
+ buf.reserve(256);
+ buf += "INSERT VERTEX ";
+ if (ifNotExists_) {
+ buf += "IF NOT EXISTS ";
+ }
+ buf += vertices_->toString();
+ return buf;
+}
+
 std::string EdgeRowItem::toString() const {
  std::string buf;
  buf.reserve(256);

src/parser/MutateSentences.h

@@ -157,6 +157,21 @@ class InsertVerticesSentence final : public Sentence {
  std::unique_ptr<VertexRowList> rows_;
 };
 
+class InsertVerticesOnlySentence final : public Sentence {
+ public:
+ explicit InsertVerticesOnlySentence(VertexIDList *vidList, bool ifNotExists)
+ : Sentence(Kind::kInsertVerticesOnly),
+ vertices_(new VerticesClause(vidList)),
+ ifNotExists_(ifNotExists) {}
+ std::string toString() const override;
+ const VerticesClause *vertices() const { return vertices_.get(); }
+ bool ifNotExists() const { return ifNotExists_; }
+
+ private:
+ std::unique_ptr<VerticesClause> vertices_;
+ bool ifNotExists_{false};
+};
+
 class EdgeRowItem final {
  public:
  EdgeRowItem(Expression *srcid, Expression *dstid, ValueList *values) {

src/parser/Sentence.h

@@ -52,6 +52,7 @@ class Sentence {
  kDropTag,
  kDropEdge,
  kInsertVertices,
+ kInsertVerticesOnly,
  kUpdateVertex,
  kInsertEdges,
  kUpdateEdge,

src/parser/parser.yy

@@ -2785,6 +2785,9 @@ insert_vertex_sentence
  : KW_INSERT KW_VERTEX opt_if_not_exists vertex_tag_list KW_VALUES vertex_row_list {
  $$ = new InsertVerticesSentence($4, $6, $3);
  }
+ | KW_INSERT KW_VERTEX opt_if_not_exists KW_VALUES vid_list {
+ $$ = new InsertVerticesOnlySentence($5, $3);
+ }
  ;
 
 vertex_tag_list

tests/tck/features/insert/insertVertexOnly.feature

@@ -0,0 +1,32 @@
+# Copyright (c) 2021 vesoft inc. All rights reserved.
+#
+# This source code is licensed under Apache 2.0 License.
+Feature: insert vertex without tag
+
+ Background: Background name
+ Given an empty graph
+ And create a space with following options:
+ | partition_num | 9 |
+ | replica_factor | 1 |
+ | vid_type | int64 |
+
+ Scenario: insert vertex only
+ Given having executed:
+ """
+ CREATE EDGE e();
+ """
+ And wait 6 seconds
+ When executing query:
+ """
+ INSERT VERTEX VALUES 1,2,3;
+ INSERT EDGE e() VALUES 1->2:(),2->3:();
+ """
+ Then the execution should be successful
+ When executing query:
+ """
+ GO 2 STEP FROM 1 OVER e yield e._dst AS dst;
+ """
+ Then the result should be, in any order:
+ | dst |
+ | 3 |
+ Then drop the used space