Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert vertex only #3335

Merged
merged 17 commits into from
Dec 27, 2021
Merged

Insert vertex only #3335

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e786d0f
add insert vertex only parser
cangfengzhs Nov 19, 2021
0f6de68
add test
cangfengzhs Dec 15, 2021
430fd0b
format
cangfengzhs Dec 15, 2021
5f6c4d1
Merge remote-tracking branch 'vesoft/master' into insert_vertex_only
cangfengzhs Dec 20, 2021
9017391
merge master
cangfengzhs Dec 20, 2021
d1ad1c3
Merge remote-tracking branch 'vesoft/master' into insert_vertex_only
cangfengzhs Dec 20, 2021
8c4cf94
modify parser
cangfengzhs Dec 20, 2021
545bf34
add fetch test
cangfengzhs Dec 21, 2021
c60463b
Merge branch 'master' into insert_vertex_only
cangfengzhs Dec 21, 2021
4546ea7
format
cangfengzhs Dec 21, 2021
4750d17
Merge branch 'insert_vertex_only' of github.com:cangfengzhs/nebula in…
cangfengzhs Dec 21, 2021
f973567
Merge branch 'master' of https://github.com/vesoft-inc/nebula into in…
cangfengzhs Dec 24, 2021
6874699
Merge remote-tracking branch 'vesoft/master' into insert_vertex_only2
cangfengzhs Dec 27, 2021
9209622
fix fetch vertex without tag error
cangfengzhs Dec 27, 2021
aa2350b
Merge branch 'master' into insert_vertex_only
cangfengzhs Dec 27, 2021
63519a6
Merge branch 'master' into insert_vertex_only
Sophie-Xie Dec 27, 2021
414faf1
Merge branch 'master' into insert_vertex_only
Sophie-Xie Dec 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/clients/storage/StorageClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,12 @@ StorageRpcRespFuture<cpp2::GetPropResponse> StorageClient::getProps(
req.set_space_id(param.space);
req.set_parts(std::move(c.second));
req.set_dedup(dedup);
if (vertexProps != nullptr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait fix in #3443

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same. Fixing something else?

Copy link
Contributor

@Shylock-Hg Shylock-Hg Dec 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cangfengzhs Please check why vertexProp equals to null, maybe not fixed in #3443

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FetchVerticesPlanner::buildVertexProps return a nullptr when props is empty

req.set_vertex_props(*vertexProps);
}
if (edgeProps != nullptr) {
req.set_edge_props(*edgeProps);
} else if (vertexProps != nullptr) {
req.set_vertex_props(*vertexProps);
} else {
req.set_vertex_props({});
}
if (expressions != nullptr) {
req.set_expressions(*expressions);
Expand Down
8 changes: 8 additions & 0 deletions tests/tck/features/insert/insertVertexOnly.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,12 @@ Feature: insert vertex without tag
Then the result should be, in any order:
| dst |
| 3 |
When executing query:
"""
FETCH PROP ON * 1,2 yield vertex AS v;
"""
Then the result should be, in any order, with relax comparison:
| v |
| (1) |
| (2) |
Then drop the used space