Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duration. #3338

Merged
merged 29 commits into from
Dec 20, 2021
Merged

Add duration. #3338

merged 29 commits into from
Dec 20, 2021

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Nov 22, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Related to #3101

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Nov 22, 2021
@Shylock-Hg Shylock-Hg marked this pull request as draft November 22, 2021 07:06
@Shylock-Hg Shylock-Hg marked this pull request as ready for review November 30, 2021 09:07
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.92918% with 148 lines in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (99f1f7a) to head (f179fb4).
Report is 936 commits behind head on master.

Files with missing lines Patch % Lines
src/common/datatypes/DurationOps-inl.h 46.39% 52 Missing ⚠️
src/common/datatypes/Value.cpp 67.25% 37 Missing ⚠️
src/common/datatypes/Duration.h 69.81% 16 Missing ⚠️
src/common/datatypes/ValueOps-inl.h 52.94% 16 Missing ⚠️
src/common/time/TimeUtils.cpp 70.37% 8 Missing ⚠️
src/codec/RowWriterV2.cpp 76.00% 6 Missing ⚠️
src/common/function/FunctionManager.cpp 70.58% 5 Missing ⚠️
src/common/datatypes/Date.cpp 97.46% 4 Missing ⚠️
src/common/utils/IndexKeyUtils.h 0.00% 2 Missing ⚠️
src/graph/util/SchemaUtil.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3338    +/-   ##
========================================
  Coverage   85.19%   85.20%            
========================================
  Files        1304     1306     +2     
  Lines      121308   122162   +854     
========================================
+ Hits       103352   104084   +732     
- Misses      17956    18078   +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

czpmango
czpmango previously approved these changes Dec 1, 2021
czpmango
czpmango previously approved these changes Dec 2, 2021
@yixinglu
Copy link
Contributor

yixinglu commented Dec 2, 2021

What happens if we insert a duration type data?

Insert error in current.

could you add some tests for the scenario?

@Shylock-Hg
Copy link
Contributor Author

What happens if we insert a duration type data?

Insert error in current.

could you add some tests for the scenario?

Added. And support to store it.

@Shylock-Hg Shylock-Hg added doc affected PR: improvements or additions to documentation incompatible PR: incompatible with the recently released version labels Dec 3, 2021
czpmango
czpmango previously approved these changes Dec 8, 2021
Comment on lines +23 to +26
# TODO don't allow different sign
# | {months: 1, days: -14, hours: 16, minutes: -12, seconds: 70} | '1984-10-28' | '1984-09-25' |
# TODO support decimal
# | {years: 12.5, months: 5.5, days: 14.5, hours: 16.5, minutes: 12.5, seconds: 70.5} | '1997-10-11' | '1971-10-12' |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the behavior for these cases now?

@CPWstatic CPWstatic merged commit af74bab into vesoft-inc:master Dec 20, 2021
@Shylock-Hg Shylock-Hg deleted the feature/duration branch February 9, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants