Support Cluster Management #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
force-pushed
the
white-list
branch
2 times, most recently
from
86e45df to
b3735fd
Compare
7 tasks
darionyaphet
force-pushed
the
white-list
branch
4 times, most recently
from
88f47bb to
20df766
Compare
darionyaphet
force-pushed
the
white-list
branch
2 times, most recently
from
8982691 to
9ba6c21
Compare
darionyaphet
added
ready-for-testing
darionyaphet
force-pushed
the
white-list
branch
5 times, most recently
from
5b52893 to
10ddf08
Compare
darionyaphet
force-pushed
the
white-list
branch
4 times, most recently
from
f5f8803 to
bfc12a4
Compare
critical27
reviewed
Dec 6, 2021
| @@ -145,7 +177,7 @@ ErrorOr<nebula::cpp2::ErrorCode, std::vector<HostAddr>> ActiveHostsMan::getActiv | |||
| return activeHosts; | |||
| } | |||
|
|
|||
| ErrorOr<nebula::cpp2::ErrorCode, std::vector<HostAddr>> ActiveHostsMan::getActiveHostsWithGroup( | |||
| ErrorOr<nebula::cpp2::ErrorCode, std::vector<HostAddr>> ActiveHostsMan::getActiveHostsWithZones( | |||
There was a problem hiding this comment.
@liwenhui-soul This interface could be deleted? So as getActiveHostsInZone.
There was a problem hiding this comment.
sure,I don't use it any more
There was a problem hiding this comment.
ok, plz delete all related interfaces in your PR
| @@ -24,43 +24,12 @@ void DropZoneProcessor::process(const cpp2::DropZoneReq& req) { | |||
| return; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Where do we check host is empty? The space properties is not impacted?
There was a problem hiding this comment.
DROP ZONE will be fixed in the next pr. This one only remove some group related function
darionyaphet
force-pushed
the
white-list
branch
from
bfc12a4 to
b77fa59
Compare
darionyaphet
force-pushed
the
white-list
branch
2 times, most recently
from
d56c550 to
aa997e6
Compare
critical27
requested review from
Nivras,
pengweisong,
SuperYoko and
wenhaocs
critical27
reviewed
Dec 13, 2021
| @@ -145,7 +177,7 @@ ErrorOr<nebula::cpp2::ErrorCode, std::vector<HostAddr>> ActiveHostsMan::getActiv | |||
| return activeHosts; | |||
| } | |||
|
|
|||
| ErrorOr<nebula::cpp2::ErrorCode, std::vector<HostAddr>> ActiveHostsMan::getActiveHostsWithGroup( | |||
| ErrorOr<nebula::cpp2::ErrorCode, std::vector<HostAddr>> ActiveHostsMan::getActiveHostsWithZones( | |||
There was a problem hiding this comment.
ok, plz delete all related interfaces in your PR
liwenhui-soul
previously approved these changes
Dec 13, 2021
|
Please write some document about what should user do after the PR merged. |
|
I'm fix some python test case failed |
darionyaphet
dismissed stale reviews from liwenhui-soul and critical27
via
283e686
darionyaphet
force-pushed
the
white-list
branch
from
16ad521 to
283e686
Compare
Codecov Report
@@ Coverage Diff @@
## master #3343 +/- ##
==========================================
- Coverage 85.40% 85.21% -0.20%
==========================================
Files 1289 1304 +15
Lines 119798 121212 +1414
==========================================
+ Hits 102317 103292 +975
- Misses 17481 17920 +439
Continue to review full report at Codecov.
|
wenhaocs
reviewed
Dec 14, 2021
|
Otherwise, LGTM and thank you for enhancing the code out of the zoning project in this PR. |
wenhaocs
approved these changes
Dec 14, 2021
liwenhui-soul
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: