Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix geo index bound #3352

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Conversation

cangfengzhs
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@cangfengzhs cangfengzhs added the ready-for-testing PR: ready for the CI test label Nov 25, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the tests for the bugfix

@cangfengzhs
Copy link
Contributor Author

Please add the tests for the bugfix

@jievince Is there any geo test case to test index bound?

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #3352 (82aab96) into master (d06fd9f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3352      +/-   ##
==========================================
- Coverage   85.23%   85.21%   -0.02%     
==========================================
  Files        1304     1304              
  Lines      121231   121237       +6     
==========================================
- Hits       103329   103313      -16     
- Misses      17902    17924      +22     
Impacted Files Coverage Δ
src/common/geo/GeoIndex.cpp 81.17% <100.00%> (+0.45%) ⬆️
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 83.41% <0.00%> (-4.27%) ⬇️
src/graph/executor/StorageAccessExecutor.h 66.66% <0.00%> (-2.57%) ⬇️
src/common/base/Status.h 88.63% <0.00%> (-2.28%) ⬇️
src/storage/exec/QueryUtils.h 91.42% <0.00%> (-1.78%) ⬇️
src/common/expression/LogicalExpression.cpp 91.66% <0.00%> (-1.73%) ⬇️
src/kvstore/DiskManager.cpp 86.51% <0.00%> (-1.13%) ⬇️
src/common/meta/ServerBasedSchemaManager.cpp 84.37% <0.00%> (-1.05%) ⬇️
src/kvstore/Part.cpp 54.13% <0.00%> (-0.57%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06fd9f...82aab96. Read the comment docs.

@cangfengzhs cangfengzhs marked this pull request as ready for review December 15, 2021 03:50
@critical27 critical27 merged commit df3781c into vesoft-inc:master Dec 15, 2021
@jievince
Copy link
Contributor

Please add the tests for the bugfix

@jievince Is there any geo test case to test index bound?

I have added some cases in #3396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants