To support delete in toss. #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyu85cn
force-pushed
the
toss-delete
branch
2 times, most recently
from
6da5429
to
89db998
Compare
liuyu85cn
force-pushed
the
toss-delete
branch
2 times, most recently
from
421473b
to
764eb93
Compare
Codecov Report
@@ Coverage Diff @@
## master #3374 +/- ##
==========================================
+ Coverage 85.40% 85.76% +0.36%
==========================================
Files 1289 1319 +30
Lines 119798 128132 +8334
==========================================
+ Hits 102317 109898 +7581
- Misses 17481 18234 +753
Continue to review full report at Codecov.
|
panda-sheep
reviewed
Dec 23, 2021
liuyu85cn
force-pushed
the
toss-delete
branch
2 times, most recently
from
79537b4
to
c618df7
Compare
dummy copy from chain add edges processor reguraly update some update may compile add some simple UT adjusting UT add explain DeleteEdgesRequest add some UT clear reverse table early expose storage interface update license & fix gcc compile error fix compile error update license fix chain interface bug fix mem-leak rename some processor continue rename Processor add some log for debug print readable edge debug keys when delete print conflict key and scanned key print rank delPrime delete the wrong key from memory lock fix raft may rollback want we scanned
liuyu85cn
force-pushed
the
toss-delete
branch
from
af14782
to
906722b
Compare
critical27
reviewed
Dec 28, 2021
critical27
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
support delete out/in edges in TOSS.
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: