Balance #3394
Merged
Balance #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenhui-soul
force-pushed
the
balance
branch
3 times, most recently
from
0970fe0
to
8ef5d52
Compare
liwenhui-soul
force-pushed
the
balance
branch
from
8ef5d52
to
583e3b9
Compare
critical27
requested review from
panda-sheep,
cangfengzhs,
liuyu85cn,
Nivras,
pengweisong,
SuperYoko and
wenhaocs
liwenhui-soul
force-pushed
the
balance
branch
4 times, most recently
from
f6cc878
to
a52fb46
Compare
liwenhui-soul
force-pushed
the
balance
branch
from
41ae899
to
813ea63
Compare
|
Can you put description of this PR at the beginning?
A clear description is as important as code. Thank you |
liwenhui-soul
force-pushed
the
balance
branch
2 times, most recently
from
89f99bf
to
242d10d
Compare
liwenhui-soul
added
doc affected
liwenhui-soul
force-pushed
the
balance
branch
from
242d10d
to
6271589
Compare
Codecov Report
@@ Coverage Diff @@
## master #3394 +/- ##
==========================================
- Coverage 85.19% 85.13% -0.07%
==========================================
Files 1304 1315 +11
Lines 121308 121302 -6
==========================================
- Hits 103352 103265 -87
- Misses 17956 18037 +81
Continue to review full report at Codecov.
|
wenhaocs
reviewed
Dec 16, 2021
| sortedHosts.front()->parts_.emplace(partId); | ||
| zone->partNum_++; | ||
| HostAddr ha = sortedHosts.front()->ha_; | ||
| for (size_t i = 0; i < sortedHosts.size() - 1; i++) { |
There was a problem hiding this comment.
Why don't you loop the sorted hosts and find the first host which meets:
sortedHosts[i]->parts_.size() < sortedHosts[i + 1]
to avoid swap?
There was a problem hiding this comment.
Why don't you loop the sorted hosts and find the first host which meets:
sortedHosts[i]->parts_.size() < sortedHosts[i + 1]to avoid swap?
swap pointers is not performance sensitive and it's easy to understand
| for (; newLeftIndex < leftEnd - 1; newLeftIndex++) { | ||
| if (sortedActiveZones[newLeftIndex]->partNum_ > | ||
| sortedActiveZones[newLeftIndex + 1]->partNum_) { | ||
| std::swap(sortedActiveZones[newLeftIndex], sortedActiveZones[newLeftIndex + 1]); |
There was a problem hiding this comment.
the same, why not pick the right zone to insert to avoid swap?
critical27
previously approved these changes
Dec 24, 2021
liwenhui-soul
force-pushed
the
balance
branch
from
b332efb
to
aa58501
Compare
wenhaocs
previously approved these changes
Dec 24, 2021
liwenhui-soul
force-pushed
the
balance
branch
5 times, most recently
from
f2db882
to
691ad62
Compare
critical27
previously approved these changes
Dec 27, 2021
liwenhui-soul
force-pushed
the
balance
branch
from
691ad62
to
112e6c5
Compare
critical27
previously approved these changes
Dec 28, 2021
wenhaocs
reviewed
Dec 28, 2021
| nebula::kvstore::KVStore* kvStore_{nullptr}; | ||
| AdminClient* adminClient_{nullptr}; | ||
|
|
||
| std::mutex muReportFinish_; | ||
| std::mutex muJobFinished_; | ||
| std::atomic<JbmgrStatus> status_ = JbmgrStatus::NOT_START; |
|
|
||
| /* first, move the lostZones' parts to the active zones | ||
| * second, make balance for the active zones */ | ||
| Status ZoneBalanceJobExecutor::buildBalancePlan() { |
There was a problem hiding this comment.
Good to see comments added!
liwenhui-soul
force-pushed
the
balance
branch
from
112e6c5
to
6f5646e
Compare
wenhaocs
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
#3169
#3432
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
https://confluence.nebula-graph.io/pages/viewpage.action?pageId=10729589
Release notes：
Please confirm whether to reflect in release notes and how to describe: