Remove extra field. #3427
Merged
Remove extra field. #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Close #3421 |
|
Does this PR require modification from storage clients? |
Yes. |
Codecov Report
@@ Coverage Diff @@
## master #3427 +/- ##
==========================================
+ Coverage 85.24% 85.34% +0.10%
==========================================
Files 1278 1278
Lines 119200 119189 -11
==========================================
+ Hits 101608 101718 +110
+ Misses 17592 17471 -121
Continue to review full report at Codecov.
|
Nicole00
reviewed
Dec 9, 2021
| @@ -561,9 +561,8 @@ struct LookupAndTraverseRequest { | |||
| */ | |||
|
|
|||
| struct ScanCursor { | |||
| 3: bool has_next, | |||
| // next start key of scan, only valid when has_next is true | |||
There was a problem hiding this comment.
how client knows the scan has get to end？
There was a problem hiding this comment.
When 'next_cursor' is null.
|
Close #3467 |
jievince
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
Close #3421
Close #3467
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: