[Raft] refactor processAppendLogRequest #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
kikimo,
darionyaphet,
sherman-the-tank,
Nivras,
wenhaocs,
cangfengzhs,
liwenhui-soul,
liuyu85cn,
panda-sheep,
SuperYoko and
pengweisong
Codecov Report
@@ Coverage Diff @@
## master #3435 +/- ##
========================================
Coverage 85.19% 85.19%
========================================
Files 1304 1305 +1
Lines 121308 121417 +109
========================================
+ Hits 103352 103445 +93
- Misses 17956 17972 +16
Continue to review full report at Codecov.
|
critical27
force-pushed
the
append
branch
2 times, most recently
from
cf1c660 to
444daea
Compare
|
Ready to review |
SuperYoko
reviewed
Dec 19, 2021
This was referenced Dec 23, 2021
Closed
wenhaocs
previously approved these changes
Dec 24, 2021
Use the same raft rpc timeout is ok, previously there is a bug, so election use an another timeout. |
SuperYoko
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change notes:
Main change is in
processAppendLogRequestA brief flow as follows (not exactly same in code):
To achieve this goal, some others need to be modified:
committedLogIdandcommittedLogTermin resp. But committedLogTerm is missing previously, so I add one.We need to make sure
lastLogId_ == wal_->lastLogId()in almost every case (except leader is replicating), we did this by callingwal_->rollbackToLog, since we handleAppendLogcorrectly, we don't need to rollback anymore, just setlastLogId_ = wal_->lastLogId()is enough.All request and resp should carry the term, step down as follower when a higher term found, otherwise we may failed to elect a leader.
micor changes: make
RaftPart::cleanupatomic