Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the latency type in the executionResponse #3438

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Dec 8, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Fix the latency type in the executionResponse. The inconsistent datatype of latency between the definition in thrift file and Response.h causes client transport invalid data lengtherror.

Which issue(s)/PR(s) this PR relates to?

This PR #2858 only modified the latency in the thrift file but left other definitions behind.

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@Aiee Aiee added ready-for-testing PR: ready for the CI test severity/blocker Severity of bug labels Dec 8, 2021
yixinglu
yixinglu previously approved these changes Dec 9, 2021
@Sophie-Xie Sophie-Xie requested a review from CPWstatic December 9, 2021 02:13
Copy link
Contributor

@czpmango czpmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@codecov-commenter
Copy link

Codecov Report

Merging #3438 (5eaf6c4) into master (6ccf173) will decrease coverage by 0.63%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3438      +/-   ##
==========================================
- Coverage   85.25%   84.61%   -0.64%     
==========================================
  Files        1278     1278              
  Lines      119277   119283       +6     
==========================================
- Hits       101688   100930     -758     
- Misses      17589    18353     +764     
Impacted Files Coverage Δ
src/common/graph/Response.h 45.66% <ø> (ø)
src/graph/validator/GoValidator.cpp 96.25% <72.72%> (-0.94%) ⬇️
src/common/graph/ExecutionResponseOps-inl.h 62.85% <85.71%> (+1.71%) ⬆️
src/meta/processors/job/AdminJobProcessor.h 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/job/FlushJobExecutor.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/job/ReportTaskProcessor.h 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/job/CompactJobExecutor.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/job/RebuildTagJobExecutor.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/job/RebuildEdgeJobExecutor.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/meta/processors/parts/CreateSpaceAsProcessor.h 0.00% <0.00%> (-100.00%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2f4a6...5eaf6c4. Read the comment docs.

@yixinglu yixinglu merged commit 65ab058 into vesoft-inc:master Dec 9, 2021
@Aiee Aiee deleted the fix-latency branch December 9, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test severity/blocker Severity of bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants