-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the latency type in the executionResponse #3438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Codecov Report
@@ Coverage Diff @@
## master #3438 +/- ##
==========================================
- Coverage 85.25% 84.61% -0.64%
==========================================
Files 1278 1278
Lines 119277 119283 +6
==========================================
- Hits 101688 100930 -758
- Misses 17589 18353 +764
Continue to review full report at Codecov.
|
What type of PR is this?
What does this PR do?
Fix the latency type in the
executionResponse
. The inconsistent datatype of latency between the definition inthrift
file andResponse.h
causes client transportinvalid data length
error.Which issue(s)/PR(s) this PR relates to?
This PR #2858 only modified the
latency
in thethrift
file but left other definitions behind.Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: