-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema support mixed Chinese and English #3440
Merged
yixinglu
merged 4 commits into
vesoft-inc:master
from
heroicNeZha:mixed_chinese_englist
Dec 13, 2021
Merged
Schema support mixed Chinese and English #3440
yixinglu
merged 4 commits into
vesoft-inc:master
from
heroicNeZha:mixed_chinese_englist
Dec 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heroicNeZha
added
doc affected
PR: improvements or additions to documentation
ready-for-testing
PR: ready for the CI test
labels
Dec 9, 2021
jievince
reviewed
Dec 9, 2021
heroicNeZha
force-pushed
the
mixed_chinese_englist
branch
from
December 9, 2021 02:58
677d92a
to
0e56964
Compare
heroicNeZha
force-pushed
the
mixed_chinese_englist
branch
2 times, most recently
from
December 9, 2021 10:38
e5c943d
to
3a05b98
Compare
CPWstatic
previously approved these changes
Dec 9, 2021
yixinglu
reviewed
Dec 10, 2021
heroicNeZha
force-pushed
the
mixed_chinese_englist
branch
from
December 10, 2021 04:07
3a05b98
to
11d9098
Compare
Codecov Report
@@ Coverage Diff @@
## master #3440 +/- ##
==========================================
+ Coverage 85.23% 85.31% +0.08%
==========================================
Files 1277 1289 +12
Lines 119088 119823 +735
==========================================
+ Hits 101502 102232 +730
- Misses 17586 17591 +5
Continue to review full report at Codecov.
|
CPWstatic
approved these changes
Dec 11, 2021
yixinglu
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc affected
PR: improvements or additions to documentation
ready-for-testing
PR: ready for the CI test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Schema support mixed Chinese and English
Which issue(s)/PR(s) this PR relates to?
close #3426
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: