-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust get neighbor plan #3458
Adjust get neighbor plan #3458
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3458 +/- ##
=========================================
Coverage 85.23% 85.23%
=========================================
Files 1277 1308 +31
Lines 119088 122744 +3656
=========================================
+ Hits 101502 104622 +3120
- Misses 17586 18122 +536
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor issues. Just want to make sure the logic is "if not edge specified, return only the vertex properties". Can you also give an update of the current behavior of GetNeighbors
in the description of this PR and GetNeighborsProcessor.cpp
?
f7b8726
to
0dc277c
Compare
80672f4
to
88b1ebc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
2039e09
+----+---+ | ||
|TagNodes| | ||
+--------+ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: