Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save client version #3483

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Conversation

heroicNeZha
Copy link
Contributor

@heroicNeZha heroicNeZha commented Dec 16, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

There are two versions here.
One is the protocol version in thrift, which is used to verify compatibility through the whitelist;
the other is the packaged version, which is tag or datetime-nightly.

+-------------+-------+----------+-----------+--------------+----------------+
| Host | Port | Status | Role | Git Info Sha | Version |
+-------------+-------+----------+-----------+--------------+----------------+
| "127.0.0.1" | 21079 | "ONLINE" | "STORAGE" | "75f11121" | "datetime-nightly" |
+-------------+-------+----------+-----------+--------------+----------------+

Which issue(s)/PR(s) this PR relates to?

closes #3479

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@heroicNeZha heroicNeZha added the ready-for-testing PR: ready for the CI test label Dec 16, 2021
yixinglu
yixinglu previously approved these changes Dec 16, 2021
@heroicNeZha heroicNeZha force-pushed the store_client_version branch 2 times, most recently from f33979d to c4dd5e9 Compare December 16, 2021 08:20
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2021

Codecov Report

Merging #3483 (a35fdfe) into master (99f1f7a) will increase coverage by 0.00%.
The diff coverage is 96.25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3483   +/-   ##
=======================================
  Coverage   85.19%   85.20%           
=======================================
  Files        1304     1304           
  Lines      121308   121349   +41     
=======================================
+ Hits       103352   103395   +43     
+ Misses      17956    17954    -2     
Impacted Files Coverage Δ
src/clients/storage/StorageClient.h 100.00% <ø> (ø)
src/clients/storage/StorageClientBase-inl.h 74.61% <ø> (+1.93%) ⬆️
src/graph/validator/MutateValidator.h 100.00% <ø> (ø)
src/storage/mutate/AddEdgesProcessor.h 100.00% <ø> (ø)
src/storage/mutate/AddVerticesProcessor.h 100.00% <ø> (ø)
src/storage/mutate/AddEdgesProcessor.cpp 59.86% <78.57%> (+3.20%) ⬆️
src/clients/meta/MetaClient.cpp 74.39% <100.00%> (-0.16%) ⬇️
src/clients/storage/StorageClient.cpp 78.51% <100.00%> (+0.07%) ⬆️
src/graph/executor/mutate/InsertExecutor.cpp 100.00% <100.00%> (ø)
src/graph/planner/plan/Mutate.h 100.00% <100.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14aa0e...a35fdfe. Read the comment docs.

@yixinglu yixinglu merged commit 2beee55 into vesoft-inc:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The nightly installation package displays the wrong version
6 participants