-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save client version #3483
Merged
Merged
save client version #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
previously approved these changes
Dec 16, 2021
Shylock-Hg
reviewed
Dec 16, 2021
heroicNeZha
force-pushed
the
store_client_version
branch
from
December 16, 2021 07:56
ae5ae3e
to
c916fd8
Compare
Shylock-Hg
reviewed
Dec 16, 2021
heroicNeZha
force-pushed
the
store_client_version
branch
2 times, most recently
from
December 16, 2021 08:20
f33979d
to
c4dd5e9
Compare
heroicNeZha
force-pushed
the
store_client_version
branch
from
December 16, 2021 08:21
c4dd5e9
to
572a406
Compare
Shylock-Hg
approved these changes
Dec 16, 2021
HarrisChu
reviewed
Dec 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #3483 +/- ##
=======================================
Coverage 85.19% 85.20%
=======================================
Files 1304 1304
Lines 121308 121349 +41
=======================================
+ Hits 103352 103395 +43
+ Misses 17956 17954 -2
Continue to review full report at Codecov.
|
Aiee
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
There are two versions here.
One is the protocol version in thrift, which is used to verify compatibility through the whitelist;
the other is the packaged version, which is tag or datetime-nightly.
+-------------+-------+----------+-----------+--------------+----------------+
| Host | Port | Status | Role | Git Info Sha | Version |
+-------------+-------+----------+-----------+--------------+----------------+
| "127.0.0.1" | 21079 | "ONLINE" | "STORAGE" | "75f11121" | "datetime-nightly" |
+-------------+-------+----------+-----------+--------------+----------------+
Which issue(s)/PR(s) this PR relates to?
closes #3479
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: