Add snowflake id #3500
Merged
Add snowflake id #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPWstatic
reviewed
Dec 20, 2021
src/common/expression/CMakeLists.txt
Outdated
| @@ -32,6 +32,7 @@ nebula_add_library( | |||
| PredicateExpression.cpp | |||
| ListComprehensionExpression.cpp | |||
| ReduceExpression.cpp | |||
| ../id/SnowFlake.cpp | |||
There was a problem hiding this comment.
You could add a new object for the ids.
| UNUSED(ctx); | ||
| SnowFlake generator; |
There was a problem hiding this comment.
Why always new a generator?
src/common/id/SnowFlake.h
Outdated
| int64_t getId(); | ||
|
|
||
| private: | ||
| mutable std::mutex lock_; |
There was a problem hiding this comment.
Why we still have s lock here?
jackwener
commented
Dec 23, 2021
| UNUSED(ctx); | ||
| Snowflake generator; | ||
| result_ = generator.getId(); |
There was a problem hiding this comment.
add a long term generator for client
src/common/id/test/CMakeLists.txt
Outdated
| $<TARGET_OBJECTS:base_obj> | ||
| $<TARGET_OBJECTS:snowflake_obj> | ||
| LIBRARIES gtest gtest_main | ||
| ) |
jackwener
commented
Dec 27, 2021
jackwener
force-pushed
the
snowflakeId
branch
from
990e4d6 to
232d11b
Compare
yixinglu
reviewed
Dec 27, 2021
src/graph/util/test/CMakeLists.txt
Outdated
| @@ -8,6 +8,7 @@ nebula_add_test( | |||
| $<TARGET_OBJECTS:concurrent_obj> | |||
| $<TARGET_OBJECTS:datatypes_obj> | |||
| $<TARGET_OBJECTS:expression_obj> | |||
| $<TARGET_OBJECTS:snowflake_obj> | |||
jackwener
force-pushed
the
snowflakeId
branch
from
4271b48 to
7ed4877
Compare
CPWstatic
reviewed
Dec 27, 2021
jievince
reviewed
Dec 30, 2021
jievince
reviewed
Dec 30, 2021
yixinglu
approved these changes
Dec 30, 2021
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* snowflake id * fix bug * fix review * remove redundant * tmp * tmp * finish * fix * fix * fix header * fix header * fix format * fix test * fix review * fix bench * add 64 * fix review * fix review * fix viarable Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
close #3447
What this PR does / why we need it?
Add a kind of unquie id
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: