-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push aggregate in LookupIndex #3504
Conversation
dc5d038
to
5fc8669
Compare
cf00464
to
51a87f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goood job~~ Generally LGTM, clean code
51a87f2
to
40d620f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ed2b9b4
to
5c0f8ca
Compare
What type of PR is this?
What does this PR do?
LookupIndexRequest can receive the statProps info, and do aggregate in storage.
This PR add a new node(IndexAggregateNode) for LookupIndexPlan, it will check and append the columns which in statProp but not in returnColumns, and append it in returnColumns.
IndexProjectNode before this PR will return the row in the order of returnColumns, after this PR, it will return returnColumns + statProps(which the statProp not in returnColumns). and IndexAggregateNode will truncate the Row, only real returnColumns append into resultDataSet, and calculate the aggregate expression and return the result.
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: