Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated function usage #3528

Merged
merged 9 commits into from
Dec 25, 2021
Merged

Conversation

yixinglu
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Dec 22, 2021
@yixinglu yixinglu changed the title Fix format Replace deprecated folly::format with folly::sformat Dec 22, 2021
jievince
jievince previously approved these changes Dec 22, 2021
Shylock-Hg
Shylock-Hg previously approved these changes Dec 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3528 (bf51a4e) into master (53b85dc) will decrease coverage by 0.01%.
The diff coverage is 83.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3528      +/-   ##
==========================================
- Coverage   85.19%   85.18%   -0.02%     
==========================================
  Files        1306     1307       +1     
  Lines      122158   122553     +395     
==========================================
+ Hits       104078   104402     +324     
- Misses      18080    18151      +71     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 95.65% <ø> (ø)
src/common/expression/VariableExpression.cpp 84.84% <ø> (-0.45%) ⬇️
src/common/geo/GeoIndex.h 100.00% <ø> (ø)
src/graph/executor/maintain/EdgeIndexExecutor.cpp 92.06% <ø> (ø)
src/graph/executor/maintain/TagIndexExecutor.cpp 92.80% <ø> (ø)
...rc/graph/executor/query/AppendVerticesExecutor.cpp 98.30% <ø> (ø)
src/graph/executor/query/GetEdgesExecutor.cpp 94.00% <ø> (ø)
src/graph/executor/query/GetVerticesExecutor.cpp 96.77% <ø> (ø)
src/graph/executor/query/IndexScanExecutor.cpp 88.88% <ø> (ø)
src/graph/optimizer/rule/IndexScanRule.h 100.00% <ø> (ø)
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408d731...bf51a4e. Read the comment docs.

@yixinglu yixinglu changed the title Replace deprecated folly::format with folly::sformat Replace deprecated function usage Dec 25, 2021
@yixinglu yixinglu changed the title Replace deprecated function usage Fix deprecated function usage Dec 25, 2021
@yixinglu yixinglu merged commit 6c81a5a into vesoft-inc:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants