-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated function usage #3528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
changed the title
Fix format
Replace deprecated folly::format with folly::sformat
Dec 22, 2021
jievince
previously approved these changes
Dec 22, 2021
Shylock-Hg
previously approved these changes
Dec 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #3528 +/- ##
==========================================
- Coverage 85.19% 85.18% -0.02%
==========================================
Files 1306 1307 +1
Lines 122158 122553 +395
==========================================
+ Hits 104078 104402 +324
- Misses 18080 18151 +71
Continue to review full report at Codecov.
|
yixinglu
requested review from
jievince,
Shylock-Hg,
critical27,
Aiee,
czpmango and
nevermore3
December 25, 2021 08:08
yixinglu
changed the title
Replace deprecated folly::format with folly::sformat
Replace deprecated function usage
Dec 25, 2021
yixinglu
changed the title
Replace deprecated function usage
Fix deprecated function usage
Dec 25, 2021
jievince
approved these changes
Dec 25, 2021
nevermore3
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?