Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable breakpad in no-release version #3533

Merged
merged 20 commits into from
Mar 24, 2022
Merged

Disable breakpad in no-release version #3533

merged 20 commits into from
Mar 24, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Dec 22, 2021 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Dec 22, 2021
@jievince
Copy link
Contributor

Why disable it?

@Shylock-Hg
Copy link
Contributor Author

Why disable it?

Debug build don't need it.

@CPWstatic
Copy link
Contributor

Would it be better by providing an specific definition for breakpad? Such as ENABLE_BREAKPAD.

@Shylock-Hg
Copy link
Contributor Author

Would it be better by providing an specific definition for breakpad? Such as ENABLE_BREAKPAD.

Ok, done.

CPWstatic
CPWstatic reviewed Jan 10, 2022
View reviewed changes
package/package.sh Outdated Show resolved Hide resolved
@Shylock-Hg Shylock-Hg requested a review from CPWstatic January 11, 2022 08:32
@Shylock-Hg Shylock-Hg changed the title Disable breakpad in debug mode. Disable breakpad in no-release version Jan 11, 2022
CPWstatic
CPWstatic previously approved these changes Mar 10, 2022
View reviewed changes
@Shylock-Hg Shylock-Hg requested a review from CPWstatic March 11, 2022 02:47
@Sophie-Xie Sophie-Xie removed the request for review from czpmango March 15, 2022 13:00
CPWstatic
CPWstatic previously approved these changes Mar 18, 2022
View reviewed changes
yixinglu
yixinglu reviewed Mar 18, 2022
View reviewed changes
package/package.sh Outdated Show resolved Hide resolved
src/daemons/GraphDaemon.cpp Outdated Show resolved Hide resolved
yixinglu
yixinglu reviewed Mar 21, 2022
View reviewed changes
src/daemons/SetupBreakpad.cpp Outdated Show resolved Hide resolved
cmake/nebula/ThirdPartyConfig.cmake Outdated Show resolved Hide resolved
CPWstatic
CPWstatic previously approved these changes Mar 21, 2022
View reviewed changes
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 21, 2022
@Sophie-Xie Sophie-Xie merged commit 456a28f into vesoft-inc:master Mar 24, 2022
@Shylock-Hg Shylock-Hg deleted the nebula-breakpad branch March 24, 2022 08:14
@jamieliu1023 jamieliu1023 mentioned this pull request Mar 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPWstatic CPWstatic CPWstatic approved these changes

@yixinglu yixinglu yixinglu approved these changes

@jievince jievince Awaiting requested review from jievince

@sherman-the-tank sherman-the-tank Awaiting requested review from sherman-the-tank

@dutor dutor Awaiting requested review from dutor

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Shylock-Hg @jievince @CPWstatic @yixinglu @Sophie-Xie