Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that the query results will still contain the expired e… #3536

Merged
merged 5 commits into from
Dec 27, 2021

Conversation

luyade
Copy link
Contributor

@luyade luyade commented Dec 22, 2021

…dges if we use go reversely

What type of PR is this?

  • bug

What does this PR do?

Fix an issue that the query results still contain the expired edges when use go reversely

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Dec 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3536 (c22c1a5) into master (53b85dc) will increase coverage by 0.01%.
The diff coverage is 79.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3536      +/-   ##
==========================================
+ Coverage   85.19%   85.21%   +0.01%     
==========================================
  Files        1306     1307       +1     
  Lines      122158   122578     +420     
==========================================
+ Hits       104078   104460     +382     
- Misses      18080    18118      +38     
Impacted Files Coverage Δ
src/common/expression/VariableExpression.cpp 84.84% <ø> (-0.45%) ⬇️
...rc/graph/executor/query/AppendVerticesExecutor.cpp 98.30% <ø> (ø)
src/graph/executor/query/GetEdgesExecutor.cpp 94.00% <ø> (ø)
src/graph/executor/query/GetVerticesExecutor.cpp 96.77% <ø> (ø)
src/graph/executor/query/IndexScanExecutor.cpp 88.88% <ø> (ø)
src/graph/optimizer/rule/IndexScanRule.h 100.00% <ø> (ø)
...mizer/rule/PushLimitDownEdgeIndexRangeScanRule.cpp 20.00% <0.00%> (-0.69%) ⬇️
...raph/optimizer/rule/PushLimitDownIndexScanRule.cpp 14.81% <0.00%> (-0.57%) ⬇️
...imizer/rule/PushLimitDownTagIndexRangeScanRule.cpp 20.00% <0.00%> (-0.69%) ⬇️
src/graph/planner/plan/Query.h 97.22% <ø> (ø)
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea4889...c22c1a5. Read the comment docs.

@luyade
Copy link
Contributor Author

luyade commented Dec 23, 2021

@Sophie-Xie any comment? does it look OK?

@Sophie-Xie
Copy link
Contributor

@Sophie-Xie any comment? does it look OK?

Thanks. I assign it to others, pls wait for their review.

Copy link
Contributor

@Nivras Nivras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gooood job~ thx~ This bug must have existed for a long time

@yixinglu yixinglu merged commit 8cc544c into vesoft-inc:master Dec 27, 2021
@yixinglu yixinglu added the type/bug Type: something is unexpected label Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants