Segment auto-increasing id #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
reviewed
Dec 27, 2021
jievince
previously approved these changes
Dec 30, 2021
|
Please ignore my approval, I ordered it wrong |
jackwener
force-pushed
the
segment
branch
2 times, most recently
from
00127de to
31c6b8a
Compare
jackwener
commented
Jan 4, 2022
| @@ -25,6 +26,8 @@ void UUIDExpression::resetFrom(Decoder& decoder) { | |||
|
|
|||
| const Value& UUIDExpression::eval(ExpressionContext& ctx) { | |||
| UNUSED(ctx); | |||
| SegmentId& generator = SegmentId::getInstance(10000); | |||
There was a problem hiding this comment.
TODO: need to do multiple instance of segment id and snowflake id
jackwener
added
ready for review
ready-for-testing
jievince
reviewed
Jan 4, 2022
jievince
reviewed
Jan 4, 2022
jievince
previously approved these changes
Jan 4, 2022
src/common/id/SegmentId.h
Outdated
|
|
||
| private: | ||
| explicit SegmentId(int64_t step) : step_(step) { | ||
| segmentStart_ = fetchSegment(); | ||
| auto xRet = fetchSegment(); |
There was a problem hiding this comment.
xRet may not be ok, so you need to move this logic to a init() func.
yixinglu
reviewed
Jan 4, 2022
jackwener
force-pushed
the
segment
branch
2 times, most recently
from
ef7e3b0 to
f50c986
Compare
jievince
reviewed
Jan 5, 2022
jackwener
force-pushed
the
segment
branch
2 times, most recently
from
03d826a to
88afdda
Compare
yixinglu
reviewed
Jan 6, 2022
jievince
approved these changes
Mar 18, 2022
CPWstatic
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
close #3448
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: