Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake statobj for standalone version #3574

Merged
merged 4 commits into from
Dec 28, 2021
Merged

Fix cmake statobj for standalone version #3574

merged 4 commits into from
Dec 28, 2021

Conversation

SuperYoko
Copy link
Contributor

@SuperYoko SuperYoko commented Dec 28, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Fix standalone cmake.
storage_common_obj is splited into
$<TARGET_OBJECTS:graph_stats_obj>
$<TARGET_OBJECTS:meta_client_stats_obj>
$<TARGET_OBJECTS:storage_client_stats_obj>
Which is not applyed into standalone version

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@SuperYoko SuperYoko added ready for review ready-for-testing PR: ready for the CI test labels Dec 28, 2021
@SuperYoko SuperYoko requested review from critical27 and a team December 28, 2021 04:00
Aiee
Aiee previously approved these changes Dec 28, 2021
critical27
critical27 previously approved these changes Dec 28, 2021
darionyaphet
darionyaphet previously approved these changes Dec 28, 2021
Copy link
Contributor

@darionyaphet darionyaphet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperYoko SuperYoko removed ready-for-testing PR: ready for the CI test ready for review labels Dec 28, 2021
@SuperYoko SuperYoko dismissed stale reviews from darionyaphet, critical27, and Aiee via 4aa3332 December 28, 2021 04:22
@SuperYoko SuperYoko added ready-for-testing PR: ready for the CI test ready for review labels Dec 28, 2021
@critical27 critical27 merged commit 74464bf into vesoft-inc:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants