Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parser memeory leak #3575

Merged
merged 1 commit into from
Dec 28, 2021
Merged

fix parser memeory leak #3575

merged 1 commit into from
Dec 28, 2021

Conversation

jievince
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Close #3564

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

nevermore3
nevermore3 previously approved these changes Dec 28, 2021
View reviewed changes
yixinglu
yixinglu previously approved these changes Dec 28, 2021
View reviewed changes
@yixinglu yixinglu added ready for review ready-for-testing PR: ready for the CI test labels Dec 28, 2021
@jievince jievince dismissed stale reviews from yixinglu and nevermore3 via 41f952f December 28, 2021 09:02
@yixinglu yixinglu merged commit 7398d80 into vesoft-inc:master Dec 28, 2021
@jievince jievince deleted the parser-memroy-leak branch December 28, 2021 11:33
@jamieliu1023 jamieliu1023 mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aiee Aiee Aiee approved these changes

@nevermore3 nevermore3 nevermore3 approved these changes

@yixinglu yixinglu Awaiting requested review from yixinglu

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix parser potential memory leak when throw exception
4 participants
@jievince @yixinglu @nevermore3 @Aiee