Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
After third-party upgrade to 3.0, I found the SSL over self signed certificate can't work well again, I track from fbthrift to openssl and check related commits/release notes, but don't found anything. Finally found the mistake modification in #3263 by binary search debug between commits.
Why this issue don't report in CI? Because in self signed certificate mode, we only enable graph SSL, and tck don't support SSL before. But now tck already support it in #3471 , so this won't be ignored again. And we also could set option to let fbthrift throw when setup SSL failed.
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: