Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable an unstable test case #3600

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Conversation

liuyu85cn
Copy link
Contributor

@liuyu85cn liuyu85cn commented Dec 29, 2021

What type of PR is this?

  • [ X] bug

What does this PR do?

It is reported some CI failed of chain_delete_test.Test5

can't repro on 211, just disable it for a while.

(It is weird that test5 and test6 is almost same... why test 6 not failed???)

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

jievince
jievince previously approved these changes Dec 29, 2021
@liuyu85cn liuyu85cn added the ready-for-testing PR: ready for the CI test label Dec 29, 2021
darionyaphet
darionyaphet previously approved these changes Dec 29, 2021
@@ -219,64 +219,60 @@ TEST(ChainDeleteEdgesTest, Test4) {
std::this_thread::sleep_for(std::chrono::milliseconds(300));
}

// add some edges, then delete one of them, not execute local commit
TEST(ChainDeleteEdgesTest, Test5) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use DISABLE_Test5 to disable this test case

@liuyu85cn liuyu85cn dismissed stale reviews from darionyaphet and jievince via 5b7a027 December 29, 2021 15:02
@@ -271,9 +236,9 @@ TEST(ChainDeleteEdgesTest, Test5) {
FakeInternalStorageClient::hookInternalStorageClient(env, iClient);
ChainResumeProcessor resumeProc(env);
resumeProc.process();
// std::this_thread::sleep_for(std::chrono::milliseconds());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't remove directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is just for not cause other CI failed. Will dig more until it stable.
Thus it will have some debug code. Not sure if this is the unstable point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could convert it to a draft PR.

@yixinglu yixinglu merged commit 069125f into vesoft-inc:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants