Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix br bugs in cluster mode #3604

Merged
merged 5 commits into from
Dec 31, 2021
Merged

fix br bugs in cluster mode #3604

merged 5 commits into from
Dec 31, 2021

Conversation

pengweisong
Copy link
Contributor

@pengweisong pengweisong commented Dec 30, 2021 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

  1. fix bugs when restore.
  2. add an agent error
  3. support cmd "show hosts agent"

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

SuperYoko
SuperYoko reviewed Dec 30, 2021
View reviewed changes
resources/gflags.json Outdated Show resolved Hide resolved
Nivras
Nivras previously approved these changes Dec 30, 2021
View reviewed changes
critical27
critical27 previously approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SuperYoko
SuperYoko previously approved these changes Dec 30, 2021
View reviewed changes
@pengweisong pengweisong dismissed stale reviews from SuperYoko, critical27, and Nivras via 12c49b0 December 30, 2021 04:16
critical27
critical27 previously approved these changes Dec 30, 2021
View reviewed changes
SuperYoko
SuperYoko previously approved these changes Dec 30, 2021
View reviewed changes
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Dec 30, 2021
@pengweisong pengweisong dismissed stale reviews from SuperYoko and critical27 via 7a5fbcc December 30, 2021 08:02
@critical27 critical27 merged commit 1339554 into vesoft-inc:master Dec 31, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Jan 1, 2022
Closed
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperYoko SuperYoko SuperYoko approved these changes

@critical27 critical27 critical27 approved these changes

@Nivras Nivras Awaiting requested review from Nivras

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pengweisong @Nivras @critical27 @SuperYoko @Sophie-Xie