support bottom level compression #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panda-sheep
force-pushed
the
support_bottom_level_compression
branch
from
47eabd0 to
d1847ff
Compare
panda-sheep
requested review from
wenhaocs,
critical27,
cangfengzhs,
darionyaphet,
liuyu85cn and
a team
liuyu85cn
previously approved these changes
Jan 5, 2022
liuyu85cn
reviewed
Jan 5, 2022
src/kvstore/RocksEngineConfig.cpp
Outdated
| @@ -59,7 +59,13 @@ DEFINE_bool(enable_partitioned_index_filter, false, "True for partitioned index | |||
| DEFINE_string(rocksdb_compression, | |||
| "snappy", | |||
| "Compression algorithm used by RocksDB, " | |||
| "options: no,snappy,lz4,lz4hc,zstd,zlib,bzip2"); | |||
| "options: no,snappy,lz4,lz4hc,zstd,zlib,bzip2,xpress"); | |||
liuyu85cn
reviewed
Jan 5, 2022
wenhaocs
reviewed
Jan 5, 2022
| {"bzip2", rocksdb::kBZip2Compression}}; | ||
| {"bzip2", rocksdb::kBZip2Compression}, | ||
| {"xpress", rocksdb::kXpressCompression}, | ||
| {"disable", rocksdb::kDisableCompressionOption}}; |
There was a problem hiding this comment.
what's the difference between disable and no?
There was a problem hiding this comment.
kNoCompression means no compression
kDisableCompressionOption is used to disable some compression options.
refer to https://github.com/facebook/rocksdb/blob/fe31dc53ca04a6241a1489be826b20218dff987e/include/rocksdb/compression_type.h#L17
liuyu85cn
approved these changes
Jan 5, 2022
wenhaocs
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
support bottommost level compression
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: