Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balance fix #3775

Closed
wants to merge 6 commits into from
Closed

Balance fix #3775

wants to merge 6 commits into from

Conversation

liwenhui-soul
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@liwenhui-soul liwenhui-soul mentioned this pull request Jan 24, 2022
Closed
@liwenhui-soul liwenhui-soul added the ready-for-testing PR: ready for the CI test label Jan 24, 2022
@liwenhui-soul liwenhui-soul mentioned this pull request Jan 24, 2022
Closed
critical27
critical27 reviewed Jan 24, 2022
View reviewed changes
src/meta/processors/job/ZoneBalanceJobExecutor.cpp Outdated

bool emty = std::find_if(existTasks.begin(),
existTasks.end(),
[](std::pair<const PartitionID, std::vector<BalanceTask>>& p) {
return !p.second.empty();
}) == existTasks.end();
if (emty || rc != nebula::cpp2::ErrorCode::SUCCEEDED) {
if (emty) {
executorOnFinished_(meta::cpp2::JobStatus::FINISHED);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't recall executorOnFinished_, what is this for? Why only some of code branch need to call executorOnFinished_?

And do we need to handle LeaderBalanceJobExecutor?

Copy link
Contributor Author

@liwenhui-soul liwenhui-soul Jan 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LeaderBalanceJobExecutor

finish or stop need to call executorOnFinished_, failed don't need to. LeaderBalanceJobExecutor also do like this

@liwenhui-soul liwenhui-soul force-pushed the balance branch 4 times, most recently from aab7697 to 1335939 Compare January 26, 2022 13:35
@liwenhui-soul liwenhui-soul requested a review from a team as a code owner January 26, 2022 13:35
@liwenhui-soul liwenhui-soul force-pushed the balance branch 3 times, most recently from 30f6ab4 to bc83c80 Compare January 29, 2022 08:51
@liwenhui-soul liwenhui-soul force-pushed the balance branch 9 times, most recently from bf38f76 to 2269be4 Compare February 21, 2022 09:59
@Sophie-Xie Sophie-Xie linked an issue Feb 26, 2022 that may be closed by this pull request
submit job to balance a balanced space, job status is FAILED #3720
Closed
@Sophie-Xie Sophie-Xie linked an issue Mar 1, 2022 that may be closed by this pull request
Call thrift RunAdminJob to create a balance job, if space not existed, the job is still created #3743
Closed
@Sophie-Xie Sophie-Xie removed a link to an issue Mar 1, 2022
Call thrift RunAdminJob to create a balance job, if space not existed, the job is still created #3743
Closed
@liwenhui-soul liwenhui-soul force-pushed the balance branch 4 times, most recently from 119da8a to 7e21231 Compare March 4, 2022 02:39
@liwenhui-soul liwenhui-soul force-pushed the balance branch 9 times, most recently from ce713e3 to fdca66b Compare March 16, 2022 03:40
@liwenhui-soul
Copy link
Contributor Author

test branch, close now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 left review comments

@sherman-the-tank sherman-the-tank Awaiting requested review from sherman-the-tank

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@dutor dutor Awaiting requested review from dutor dutor is a code owner

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

submit job to balance a balanced space, job status is FAILED
2 participants
@liwenhui-soul @critical27