Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push filter down GetProps. #3844

Merged
merged 11 commits into from
Mar 1, 2022
Merged

Push filter down GetProps. #3844

merged 11 commits into from
Mar 1, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Jan 28, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #3812

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Jan 28, 2022
@Shylock-Hg Shylock-Hg changed the title Push limit down GetProps. Push filter down GetProps. Jan 29, 2022
critical27
critical27 reviewed Feb 8, 2022
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

src/storage/exec/GetPropNode.h Outdated Show resolved Hide resolved
critical27
critical27 previously approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job~

cangfengzhs
cangfengzhs approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@cangfengzhs cangfengzhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

critical27
critical27 approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job~

@critical27 critical27 merged commit 3822d76 into vesoft-inc:master Mar 1, 2022
@Shylock-Hg Shylock-Hg mentioned this pull request Mar 2, 2022
Closed
@jamieliu1023 jamieliu1023 mentioned this pull request Mar 5, 2022
Closed
@Shylock-Hg Shylock-Hg deleted the feature/push-filter-down-get-props branch March 11, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@cangfengzhs cangfengzhs cangfengzhs approved these changes

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetProps supports filter push down
4 participants
@Shylock-Hg @critical27 @cangfengzhs @Sophie-Xie