-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more table in meta dump #3870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, since you replace the literal string prefix with the one MetaKeyUtils
(I can't remember why I use literal at the first one), maybe you could replace all of them~
@critical27 The rest prefix did not have corresponding prefix function in MetaKeyUtils.cpp. Is it OK to add extra functions for this? If it's OK, I'll add them. |
Ah, I understand. It is ok to me |
4f27402
to
45cc04b
Compare
Good job |
just curious, could we move "meta_version" to table, and also dump it? |
@HarrisChu meta version is indeed in meta table, I could add it if you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Add the newly added tables in meta when dump.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: