-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments for planner. #3895
Merged
Merged
Comments for planner. #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
previously approved these changes
Feb 17, 2022
Aiee
reviewed
Feb 21, 2022
src/graph/planner/ngql/GoPlanner.cpp
Outdated
Comment on lines
93
to
95
// extract vid and edge's prop from GN | ||
// for joinDst & joinInput | ||
// output colNames {srcProps, edgeProps, kVid, "JOIN_DST_VID"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please capitalize the first character and change the verb to third person singular form.
Ref: https://google.github.io/styleguide/cppguide.html#Function_Comments
yixinglu
previously approved these changes
Mar 2, 2022
CPWstatic
force-pushed
the
comment_for_planner
branch
from
March 7, 2022 03:59
f106472
to
f8bf624
Compare
CPWstatic
force-pushed
the
comment_for_planner
branch
from
March 7, 2022 04:01
f8bf624
to
54e3dfb
Compare
Aiee
reviewed
Mar 7, 2022
Aiee
approved these changes
Mar 10, 2022
yixinglu
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Just comments.