Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix match multiple id error #3899

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Feb 15, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 added cherry-pick-v3.0 PR: need cherry-pick to this version priority/hi-pri Priority: high ready for review ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected labels Feb 15, 2022
When executing query:
"""
MATCH (a)-[e:like]->(b)
WHERE id(a) == 'Tim Duncan' OR id(b) == 'Tony Parker'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should report error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use like index not vertexIDseek

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emm. It's not related to this VIdSeek, better not put in this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you should add fail case of or expression.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emm. It's not related to this VIdSeek, better not put in this file.

it's ok to put this case here

When executing query:
"""
MATCH (a)-[e:like]->(b)
WHERE id(a) == 'Tim Duncan' OR id(b) == 'Tony Parker'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add integer vid test case too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, add case in next pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't add in this PR directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sophie-Xie waiting for this PR to publish test version

@Sophie-Xie Sophie-Xie merged commit 659d73e into vesoft-inc:master Feb 15, 2022
Sophie-Xie pushed a commit that referenced this pull request Feb 15, 2022
Sophie-Xie added a commit that referenced this pull request Feb 15, 2022
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version priority/hi-pri Priority: high ready for review ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants