Machine not registed should response leader address #3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
force-pushed
the
hb
branch
2 times, most recently
from
26a756b to
40aeed5
Compare
critical27
reviewed
Mar 4, 2022
src/clients/meta/MetaClient.cpp
Outdated
| // succeeded | ||
| pro.setValue(respGen(std::move(resp))); | ||
| return; | ||
| } else if (resp.get_code() == nebula::cpp2::ErrorCode::E_LEADER_CHANGED) { | ||
| } else if (code == nebula::cpp2::ErrorCode::E_LEADER_CHANGED || | ||
| code == nebula::cpp2::ErrorCode::E_MACHINE_NOT_FOUND) { |
There was a problem hiding this comment.
Em... if you modify in this way, how to distinguish from actual MACHINE_NOT_FOUND and MACHINE_NOT_FOUND with LEADER_CHANGE
darionyaphet
force-pushed
the
hb
branch
3 times, most recently
from
9a90e81 to
57ff7d8
Compare
critical27
approved these changes
Mar 8, 2022
pengweisong
reviewed
Mar 8, 2022
pengweisong
reviewed
Mar 8, 2022
|
fix #3591 |
darionyaphet
added a commit
to darionyaphet/nebula
that referenced
this pull request
Mar 14, 2022
Conflicts: src/meta/processors/BaseProcessor.h
Sophie-Xie
pushed a commit
that referenced
this pull request
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: