Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
refactor job manager, this pr mainly did the following parts
separation by space
Remove job_concurrency
Because only compact and flush, stats syntax supports job_concurrency, and job passes job_concurrency to task, but the corresponding task does not use job_concurrency.
Even using job_concurrency does not make much sense, because in a space, compactTask and flushTask are concurrent on the storage according to the number of engines. statsTask is concurrent according to the number of parts. FLAGS_max_concurrent_subtasks is enough
Fix bugs, such as Call thrift RunAdminJob to create a balance job, if space not existed, the job is still created #3743
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: