Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor job manager part2 #4001

Merged
merged 6 commits into from
Mar 23, 2022
Merged

refactor job manager part2 #4001

merged 6 commits into from
Mar 23, 2022

Conversation

panda-sheep
Copy link
Contributor

@panda-sheep panda-sheep commented Mar 10, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Main four parts of work
1 job manager queue
Each space has a priority queue.
Jobs in the same space are executed serially according to priority.
Jobs in different spaces are executed in parallel according to the space.
2 remove space name as the last parameter
3 Job manager refactoring
4. refactor show tag index status and show edge index status
5. Replace checkIndexJobRunning with checkTypeJobRunning to check if a certain type of job is running.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@panda-sheep panda-sheep force-pushed the refactor_job_manager_2 branch 4 times, most recently from e8f90a9 to c8cc2bf Compare March 11, 2022 03:40
@panda-sheep panda-sheep marked this pull request as ready for review March 11, 2022 03:40
@panda-sheep panda-sheep requested a review from a team as a code owner March 11, 2022 03:40
@panda-sheep panda-sheep added the ready-for-testing PR: ready for the CI test label Mar 11, 2022
@panda-sheep panda-sheep force-pushed the refactor_job_manager_2 branch from c8cc2bf to 10bcd16 Compare March 11, 2022 08:42
@panda-sheep panda-sheep force-pushed the refactor_job_manager_2 branch 3 times, most recently from 91b2001 to 423a80a Compare March 16, 2022 13:03
@panda-sheep panda-sheep force-pushed the refactor_job_manager_2 branch 3 times, most recently from 8347ba2 to 28ce1de Compare March 18, 2022 04:17
pengweisong
pengweisong previously approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@pengweisong pengweisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job~

liwenhui-soul
liwenhui-soul previously approved these changes Mar 21, 2022
View reviewed changes
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 21, 2022
@panda-sheep
refactor job manager
16ef9a9 
fuck
adjust admintask
fix rebuld tag/edge index
refactor 'show tag index status' and 'show edge index status'
support JobManager::checkTypeJobRunning
@panda-sheep
fix conflict
8109046
@panda-sheep
address pengweisong's comments
9e74c2d
@panda-sheep
improve job manager UT
20b7055
@panda-sheep panda-sheep dismissed stale reviews from liwenhui-soul and pengweisong via 20b7055 March 21, 2022 07:10
@panda-sheep panda-sheep force-pushed the refactor_job_manager_2 branch from ea16b7d to 20b7055 Compare March 21, 2022 07:10
liuyu85cn
liuyu85cn previously approved these changes Mar 21, 2022
View reviewed changes
pengweisong
pengweisong previously approved these changes Mar 21, 2022
View reviewed changes
critical27
critical27 reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an other interface setFinishCallBack in JobExecutor, we could merge it to finish. You could rewrite it if necessary.

@panda-sheep
Copy link
Contributor Author

panda-sheep commented Mar 22, 2022 •
edited
Loading

There is an other interface setFinishCallBack in JobExecutor, we could merge it to finish. You could rewrite it if necessary.

ok, next pr will do it.

@panda-sheep panda-sheep dismissed stale reviews from pengweisong and liuyu85cn via 2037a34 March 22, 2022 10:07
@panda-sheep panda-sheep force-pushed the refactor_job_manager_2 branch from 2037a34 to 24cde72 Compare March 22, 2022 10:57
@critical27
Copy link
Contributor

There is an other interface setFinishCallBack in JobExecutor, we could merge it to finish. You could rewrite it if necessary.

ok, next pr will do it.

👌 , this pr generally LGTM

critical27
critical27 previously approved these changes Mar 23, 2022
View reviewed changes
@panda-sheep panda-sheep force-pushed the refactor_job_manager_2 branch from fed8518 to e70fa86 Compare March 23, 2022 03:27
@critical27 critical27 merged commit dd270fb into vesoft-inc:master Mar 23, 2022
@panda-sheep panda-sheep deleted the refactor_job_manager_2 branch March 23, 2022 09:34
@Sophie-Xie Sophie-Xie mentioned this pull request Mar 25, 2022
Closed
@jamieliu1023 jamieliu1023 mentioned this pull request Mar 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@liwenhui-soul liwenhui-soul liwenhui-soul approved these changes

@liuyu85cn liuyu85cn liuyu85cn approved these changes

@pengweisong pengweisong pengweisong left review comments

@wenhaocs wenhaocs Awaiting requested review from wenhaocs

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@dutor dutor Awaiting requested review from dutor

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@panda-sheep @critical27 @liwenhui-soul @liuyu85cn @pengweisong @Sophie-Xie