Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor process snapshot #4019

Merged
merged 2 commits into from
Mar 18, 2022
Merged

refactor process snapshot #4019

merged 2 commits into from
Mar 18, 2022

Conversation

critical27
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

When a node receive multiple snapshot from old leader and new leader, the new snapshot can't be accept forever because the progress not match.

How do you solve it?

First verifyLeader, then check if commitId and commitTerm matches last snapshot, if not, just return error.
If the node has not received snapshot for a long time (default is 5min), will convert to follower again, so it can receive another snapshot.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:
Fix a node failed to process raft snapshot

@critical27 critical27 requested review from a team and sherman-the-tank as code owners March 11, 2022 11:53
@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Mar 11, 2022
@Shinji-IkariG Shinji-IkariG merged commit 372f6b4 into vesoft-inc:master Mar 18, 2022
@critical27 critical27 deleted the snap branch March 18, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants