Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version in docker image #4038

Closed
wants to merge 2 commits into from

Conversation

HarrisChu
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

fix #4037

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@HarrisChu HarrisChu requested a review from yixinglu March 16, 2022 03:54
@HarrisChu HarrisChu added the ready-for-testing PR: ready for the CI test label Mar 16, 2022
Aiee
Aiee previously approved these changes Mar 16, 2022
@@ -1,11 +1,14 @@
FROM vesoft/nebula-dev:centos7 as builder

ARG BRANCH=master
ARG VERSION=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to specify the VERSION argument for docker images? If there's no version parameter for package.sh script, this script will use git to generate it according to the branch.

@HarrisChu HarrisChu added the wip Solution: work in progress label Mar 18, 2022
@HarrisChu HarrisChu closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test wip Solution: work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect version in docker image
3 participants