remove learner parts when removing space #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenhui-soul
force-pushed
the
part
branch
2 times, most recently
from
6374780 to
37c1406
Compare
pengweisong
reviewed
Mar 18, 2022
liuyu85cn
reviewed
Mar 18, 2022
| @@ -581,7 +581,7 @@ class NebulaStore : public KVStore, public Handler { | |||
| * @param spaceId | |||
| * @param partId | |||
| */ | |||
| void removePart(GraphSpaceID spaceId, PartitionID partId) override; | |||
| void removePart(GraphSpaceID spaceId, PartitionID partId, bool needLock = true) override; | |||
There was a problem hiding this comment.
how about add some commet to explain in what condition needLock, or not.
There was a problem hiding this comment.
how about add some commet to explain in what condition needLock, or not.
done
liwenhui-soul
force-pushed
the
part
branch
4 times, most recently
from
0cef5cb to
8ee969e
Compare
liwenhui-soul
changed the title
| void NebulaStore::removePart(GraphSpaceID spaceId, PartitionID partId) { | ||
| folly::RWSpinLock::WriteHolder wh(&lock_); | ||
| void NebulaStore::removePart(GraphSpaceID spaceId, PartitionID partId, bool needLock) { | ||
| folly::RWSpinLock::WriteHolder wh(nullptr); |
There was a problem hiding this comment.
why append a lock on nullptr? Is this a new way?
There was a problem hiding this comment.
do nothing, you can see its code
There was a problem hiding this comment.
if so why don't remove this line?
Comment on lines
+502
to
+504
| if (needLock) { | ||
| wh.reset(&lock_); | ||
| } |
There was a problem hiding this comment.
would you support more explanation? thanks
There was a problem hiding this comment.
if need lock, wh will hold lock_
critical27
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
till now storage remove space by meta info, which does not contain learner, so the learner parts still exist after remove the space, this will cause core in next balance.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: