Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kv snapshot data inconsist #4055

Merged
merged 2 commits into from
Mar 21, 2022
Merged

fix kv snapshot data inconsist #4055

merged 2 commits into from
Mar 21, 2022

Conversation

liwenhui-soul
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

darionyaphet
darionyaphet reviewed Mar 21, 2022
View reviewed changes
src/kvstore/Part.cpp

const auto& kvPre = NebulaKeyUtils::kvPrefix(partId_);
auto ret =
batch->removeRange(NebulaKeyUtils::firstKey(kvPre, 128), NebulaKeyUtils::lastKey(kvPre, 128));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 128? Is it a magic number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relax....it's not certain yet...

Copy link
Contributor

@critical27 critical27 Mar 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how to handle it …… For example, if we want to delete part 3's kv data. The prefix is 06 03 00 00 in hex, can we delete the range by [06 03 00 00, 06 03 00 01]? Perhaps need to do some test if all data can be deleted. (I am not sure we can delete data like 06 03 00 00 FF FF FF FF ...)

@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 21, 2022
@critical27
Copy link
Contributor

Could merge it for now, the firstKey and lastKey could check later.

kikimo
kikimo approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@kikimo kikimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Mar 21, 2022
@Sophie-Xie Sophie-Xie merged commit fd8958b into vesoft-inc:master Mar 21, 2022
@jamieliu1023 jamieliu1023 mentioned this pull request Mar 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darionyaphet darionyaphet darionyaphet left review comments

@critical27 critical27 critical27 approved these changes

@kikimo kikimo kikimo approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@liwenhui-soul @critical27 @kikimo @darionyaphet @Sophie-Xie