Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug stop job before it start #4061

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

liwenhui-soul
Copy link
Contributor

@liwenhui-soul liwenhui-soul commented Mar 21, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

this pr is to solve two points:

  1. if stop a job quickly when schedule is going to start the job, it may:
    the job does not exist in runningJobs_ , but exist in inFlightJobs_, so we can't create a new one even if we stopped it.
  2. the start time of the job is 0 before starting, so it would always be expired through the calculation of duration, the job's info would be erased and we can't see it in show list.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@liwenhui-soul liwenhui-soul added the ready-for-testing PR: ready for the CI test label Mar 21, 2022
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 21, 2022
@liwenhui-soul liwenhui-soul force-pushed the lwh branch 2 times, most recently from ea3f375 to 3c985b1 Compare March 22, 2022 05:32
@liwenhui-soul liwenhui-soul force-pushed the lwh branch 3 times, most recently from 41e5739 to d6ab7a8 Compare March 24, 2022 07:38
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants