Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortest path #4071

Merged
merged 40 commits into from
Jun 7, 2022
Merged

Shortest path #4071

merged 40 commits into from
Jun 7, 2022

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Mar 23, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Traverse the data in the CartesianProduct, and call the shortestPath function for each line. each call to the shortestPath function uses a thread to execute. then write result(matched path) to the index corresponding to the resultDs_ array. finally collect the data in the resultDs_ array in the collect stage and return

How do you solve it?

image

image

image

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 23, 2022
@nevermore3 nevermore3 force-pushed the shortest_path branch 11 times, most recently from 77c2aa4 to 69ad402 Compare March 29, 2022 11:35
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.1 PR: need cherry-pick to this version label Apr 1, 2022
@Sophie-Xie Sophie-Xie removed the cherry-pick-v3.1 PR: need cherry-pick to this version label Apr 12, 2022
@Sophie-Xie Sophie-Xie removed this from the v3.1.0 milestone Apr 13, 2022
@nevermore3 nevermore3 force-pushed the shortest_path branch 2 times, most recently from 66663a8 to 15f6102 Compare April 22, 2022 07:18
@Sophie-Xie Sophie-Xie added this to the v3.2.0 milestone Apr 25, 2022
@nevermore3 nevermore3 force-pushed the shortest_path branch 10 times, most recently from 9b23f13 to 0377451 Compare April 27, 2022 12:51
@nevermore3 nevermore3 marked this pull request as ready for review April 27, 2022 15:40
@nevermore3 nevermore3 removed the incompatible PR: incompatible with the recently released version label Jun 6, 2022
@Sophie-Xie Sophie-Xie dismissed their stale review June 6, 2022 06:39

Discussed it with Mingquan offline, it is compatible.

@Sophie-Xie Sophie-Xie merged commit 56856e7 into vesoft-inc:master Jun 7, 2022
@nevermore3 nevermore3 deleted the shortest_path branch June 7, 2022 03:25
@wey-gu
Copy link
Contributor

wey-gu commented Jun 7, 2022

Cheers 🎉
ping @Reid00

@wey-gu
Copy link
Contributor

wey-gu commented Jun 7, 2022

How do you solve it?

image

image

image

This digram is phenomenal👍🏻, it'll be even better to come with both Chinese and English ;-D

@Reid00
Copy link

Reid00 commented Jun 14, 2022

is this merged on next version 3.2.0?

@wey-gu
Copy link
Contributor

wey-gu commented Jun 14, 2022

is this merged on next version 3.2.0?

yes, it's merged in master and I think will be cherry-picked to the base of 3.2.0 branch.

@Sophie-Xie
Copy link
Contributor

is this merged on next version 3.2.0?

@Reid00 Of course, it's in v3.2.0. The branch of v3.2.0 has not been pulled from master yet.

@Reid00
Copy link

Reid00 commented Jun 14, 2022

yes. I noticed that. thank you @wey-gu @Shylock-Hg I will try this feature after v3.2.0 is released.

@abby-cyber abby-cyber added the doc affected PR: improvements or additions to documentation label Jan 30, 2023
@abby-cyber
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test type/feature req Type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find All PATH enhancement
9 participants